Comments (7)
RIAEvangelist
commented on July 21, 2024
1
merged and released. Thank you :)
from node-cmd.
RIAEvangelist
commented on July 21, 2024
sounds reasonable, could you make a PR with the updates for error first?
…On Tue, Mar 21, 2017 at 5:14 AM, Stephen Last ***@***.***> wrote:
I'd like to use Bluebirds Promise.promisify
<http://bluebirdjs.com/docs/api/promise.promisify.html>.
import Promise from 'bluebird'import cmd from 'node-cmd'
const getAsync = Promise.promisify(cmd.get, { multiArgs: true, context: cmd })
getAsync('node -v').then(data => {
console.log('cmd data', data)
}).catch(err => {
console.log('cmd err', err)
})
This fails I think, because node-cmd doesn't use the standard node
error-first pattern
<https://nodejs.org/api/errors.html#errors_node_js_style_callbacks> which
Bluebird wants:
The node function should conform to node.js convention of accepting a
callback as last argument and calling that callback with error as the first
argument and success value on the second argument.
The above code calls catch but actually displays the contents of data.
Any plans to switch to standard node-style error-first callbacks..?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWhkVfJZdh-vCFsDVI-I9gve6sWwCxzks5rn78zgaJpZM4Mjtjs>
.
from node-cmd.
stephen-last
commented on July 21, 2024
Notice - this is my first time forking, cloning and submitting a pull request on Github, so if I'm not doing something right please do point me in the right direction.
I've submitted a pull request with a change to the code and readme, in a new branch.
How does it look..?
This is a breaking change, so I guess you'd need to bump the version to a new major version (3.0.0), and maybe mention the breaking change in the readme when going from v2 to v3 (I've not added this).
from node-cmd.
RIAEvangelist
commented on July 21, 2024
Why is it breaking?
from node-cmd.
RIAEvangelist
commented on July 21, 2024
nvm
from node-cmd.
stephen-last
commented on July 21, 2024
I thought this would be a breaking change because it changes the node-cmd API. Anyone currently using it will have written their code to expect data as the first param. After this PR err will be the first param.
If someone is currently using node-cmd with data as the first param, then they update node-cmd (to the version with err as the first param) their code will not work as expected.
From what I understand of semver, API breaking changes should be major updates.
Not sure why you commented with "nvm"..?
from node-cmd.
RIAEvangelist
commented on July 21, 2024
the nvm was because I realised I made a dumb comment. It was obvious why it was breaking once I looked.
from node-cmd.
Related Issues (20)
- How to use this to open an exe (Which is a CLI tool) and then fire commands HOT 1
- Output from get not displaying what outputs from the terminal HOT 2
- How to execute commands with ZSH environment HOT 1
- Not Calling Function Callback HOT 1
- Add options to exec HOT 2
- How to get stderr when using promises HOT 1
- async await example? HOT 1
- returns data missing HOT 1
- compgen -c is the only command that does not produce output HOT 1
- Can we run command as adminstrator HOT 1
- Getting stdout streaming HOT 1
- is this project still being maintained? HOT 1
- 苹果笔记本上可以使npm-cmd吗？
- Add get process by Id HOT 2
- Example Error? HOT 4
- Promise API? HOT 2
- answering to a CMD y/n prompt HOT 2
- how to kill a node-cmd process ?
- How do I run command with admin ?
- Does Node-Cmd the console close? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-cmd.