Comments (6)
@oPromessa I'm impressed with how thorough your branch is -- nice work! A couple pointers:
The "screen_shot" key should be added inasdict()
for photo PhotoInfo
and the iPhoto PhotoInfo
and it must be added in the if not shallow:
block. This prevents new keys from messing up the comparison in osxphotos export
to the stored JSON data for a photo. Only keys in the shallow=True
dictionary are compared when exporting.
Additionally, in the iPhoto test, you'll need to update the test data at tests/iphoto_test_data.json
to add the new key so the tests works.
from osxphotos.
Ran build.sh... some warnings related with latex and pdf (guess I don't have the tools)
The docs building needs work. Don't worry about this as I don't build the docs until I do the release. For individual PRs, just update the appropriate files but don't build the docs as they will get re-built as part of my release process.
from osxphotos.
On docsrc/README.md is there a typo: cd docs should be cd docsrc ?
Yes, you're right. I'll fix it.
from osxphotos.
Had to set property screen-recording to None for <= _PHOTOS_4_VERSION).
from osxphotos.
- Yeah! Basically RTFM 😉 Test Data -- BTW I've edited it a bit.
- I think I mostly got it. But have it but still question what to do in these code lines (now commented. 'cause if I uncomment,
tests/test_cli.py
fail 😢 on assert withwhere 1 = <Result KeyError('screen_recording')>.exit_code
- print_photo_info.py:L56
- print_photo_info.py:L102
- photoinfo.py:L2173
- I think I mostly got it. But have it but still question what to do in these code lines (now commented. 'cause if I uncomment,
- All tests pass now! YAY 💯
- Ran build.sh... some warnings related with latex and pdf (guess I don't have the tools). stderr: build.txt
- On docsrc/README.md is there a typo:
cd docs
should becd docsrc
? Did not want to change it, in case I was wrong. Also build.sh generates the docs. PS: Did not install MacTeX
from osxphotos.
I think I mostly got it. But have it but still question what to do in these code lines (now commented. 'cause if I uncomment, tests/test_cli.py fail 😢 on assert with where 1 = <Result KeyError('screen_recording')>.exit_code
The test_cli.py is a monster....on my to do list to break this up into smaller chunks as it has become very unwieldy.
Basically, for the tests that are failing, you need to track down where they're getting the "expected" data from. For example, in test_query_uuid()
, it's reading CLI_OUTPUT_QUERY_UUID
which is defined elsewhere in the file. This is a JSON string that will be reconstituted and compared to the JSON output of the query command. This JSON string will need to be modified to contain the screen_recording
key.
There may be other places that need to be modified.
from osxphotos.
Related Issues (20)
- Add query option for finding unnnamed faces.
- Add `--skip-raw-jpeg` as corollary for `--skip-raw`
- Add `--in-exportdb`, `--not-in-exportdb`, and `--missing-from-export` query options HOT 1
- Add pointer to export database in the export folder
- Add --not-uuid and --not-uuid-from-file HOT 1
- Warning when using --exiftool-merge-keywords and --download-missing
- Add `osxphotos cleanup` command
- KeyError: PLModelVersion HOT 3
- Add options for specifying unicode form
- osxphotos import does not correctly handle case of image_edited.jpeg + aae with no original.
- True sync when updating HOT 5
- exiftool perl process keeps running after a critical error in the python process (SEGFAULT or kill -9) HOT 3
- Refactor test_cli.py
- During export, Ignore edits that are only rotations? HOT 16
- Exporting photos, errored out, entire photo library deleted... HOT 8
- Add date / time stamp to the crash log
- Usability question: how do I get all photos and iterate over them? HOT 3
- Add "similar" photos command
- Raise error if export() with missing asset HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osxphotos.