Giter Club home page Giter Club logo

Comments (2)

RhetTbull avatar RhetTbull commented on June 11, 2024

I've been able to reproduce this. Definitely a bug so I'll create an issue from this. The problem is here in osxphotos/cli/export.py::export_cli():

        if ramdb:
            # if using ramdb, ensure database is written in case of crash
            export_db_callback = register_crash_callback(
                export_db.write_to_disk, f"Writing export database to {export_db_path}"
            )

            # install SIGINT handler to write database on Ctrl+C
            def sigint_handler(signal, frame):
                print("Aborted!", file=sys.stderr)
                print(f"Writing export database to {export_db_path}")
                export_db.write_to_disk()
                return 1

            signal.signal(signal.SIGINT, sigint_handler)

The SIGINT handler is installed to catch Ctrl+C to ensure the export database is written back to disk in the case of Ctrl+C. This was a possible source of data loss if user interrupted an export when using --ramdb, the export database could be left in a state where it didn't match the export folder. I tested this when first done but something's changed and it's definitely not aborting the code now.

from osxphotos.

RhetTbull avatar RhetTbull commented on June 11, 2024

The line return 1 should be sys.exit(1)

from osxphotos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.