Giter Club home page Giter Club logo

Comments (4)

RhetTbull avatar RhetTbull commented on May 29, 2024
  • Will need to figure out how to handle rating for Photos. Current implementation of PhotoInfo.rating returns 5 if favorite else 0. But this would make --favorite-rating actually do nothing as rating would always get written if favorite. Could change implementation of rating to return None for Photos or just get rid of --favorite-rating
   @property
    def rating(self) -> int:
        """Star rating of photo as int from 0 to 5; for iPhoto, returns star rating; for Photos, returns 5 if favorite, else 0"""
        return 5 if self.favorite else 0

from osxphotos.

RhetTbull avatar RhetTbull commented on May 29, 2024

@all-contributors please add @mlevin77 for ideas

from osxphotos.

allcontributors avatar allcontributors commented on May 29, 2024

@RhetTbull

I've put up a pull request to add @mlevin77! 🎉

from osxphotos.

RhetTbull avatar RhetTbull commented on May 29, 2024

Fixed in current branch. Will be in next release.

from osxphotos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.