Comments (9)
@all-contributors please add @finestream for bugs
from osxphotos.
I've put up a pull request to add @finestream! 🎉
from osxphotos.
I've confirmed this behavior.
IMG_4179.jpeg
IMG_4179.jpeg.xmp
IMG_4179_edited.jpeg
from osxphotos.
Problem is here:
osxphotos/osxphotos/photoexporter.py
Lines 358 to 359 in ca54c3f
The sidecar gets written only for the original file name.
from osxphotos.
If --skip-original-if-edited
is used, the edited sidecar does get generated.
from osxphotos.
Interesting....write_sidecar_files
is called for the edited file but no sidecar is written.
2024-01-01T08:55:33.437060 write_sidecar_files called from __call__ with args: () and kwargs: {'dest':
PosixPath('/Users/rhet/Desktop/export/wedding_edited.jpeg'), 'options': ExportOptions(convert_to_jpeg=False, description_template=None,
download_missing=False, dry_run=False, edited=True, exiftool_flags=(), exiftool=False, export_as_hardlink=False, export_db=<osxphotos.export_db.ExportDB
object at 0x10f26eea0>, face_regions=True, fileutil=<class 'osxphotos.fileutil.FileUtilMacOS'>, force_update=False, ignore_date_modified=False,
ignore_signature=False, increment=True, jpeg_ext=None, jpeg_quality=1.0, keyword_template=(), live_photo=True, location=True, merge_exif_keywords=False,
merge_exif_persons=False, overwrite=False, persons=True, preview_suffix='_preview', preview=False, raw_photo=False,
render_options=RenderOptions(none_str='_', path_sep='/', expand_inplace=False, inplace_sep=',', filename=False, dirname=False, strip=False,
edited_version=False, export_dir='/Users/rhet/Desktop/export', dest_path='/Users/rhet/Desktop/export',
filepath='/Users/rhet/Desktop/export/wedding_edited.jpeg', quote=False, caller='export'), replace_keywords=False, rich=True, export_aae=False,
sidecar_drop_ext=False, sidecar=0, strip=False, timeout=120, touch_file=False, update=False, update_errors=False, use_albums_as_keywords=False,
use_persons_as_keywords=False, use_photokit=False, use_photos_export=False, verbose=<function noop at 0x10eb8d6c0>, tmpdir=None, favorite_rating=False)}
2024-01-01T08:55:33.437060 write_sidecar_files returned: ExportResults(datetime=2024-01-01T08:55:33.455364, converted_to_jpeg=[], deleted_directories=[],
deleted_files=[], error=[], exif_updated=[], exiftool_error=[], exiftool_warning=[], exported=[], exported_album=[], metadata_changed=[], missing=[],
missing_album=[], new=[], aae_written=[], sidecar_exiftool_skipped=[], sidecar_exiftool_written=[], sidecar_json_skipped=[], sidecar_json_written=[],
sidecar_xmp_skipped=[], sidecar_xmp_written=[], sidecar_user_written=[], sidecar_user_skipped=[], sidecar_user_error=[], skipped=[], skipped_album=[],
to_touch=[], touched=[], updated=[], xattr_skipped=[], xattr_written=[], user_written=[], user_skipped=[], user_error=[]), elapsed time:
0.00018601398915052414 sec
from osxphotos.
write_sidecar_files
is being called with sidecar=0
for the edited file.
from osxphotos.
Found the issue...was in the cli/export.py
code.
from osxphotos.
Fixed in v0.67.2
from osxphotos.
Related Issues (20)
- Allow `--save-config` to use a template string.
- Use cgmetadata to read metadata during import
- Error copying file: "Permission denied" HOT 6
- Ability to resize on convert-to-jpeg HOT 5
- Add --skip-photos, --skip-videos/--skip-movies
- Collections and Moments HOT 1
- Warn user if Photos path cannot be accessed HOT 4
- (User error!) Photos with 1 Live photo (pic+video) and a separate video with same filename: Separate video file gets overwritten. HOT 3
- filepath.* in filename_template results in `TypeError: argument should be a str or an os.PathLike object where __fspath__ returns a str, not 'NoneType` HOT 5
- add PhotoInfo.imported_by
- Add `osxphotos check` command to check access permissions
- Provide way to override "found other export database files" warning HOT 7
- Add query option for finding unnnamed faces.
- Add `--skip-raw-jpeg` as corollary for `--skip-raw`
- Add `--in-exportdb`, `--not-in-exportdb`, and `--missing-from-export` query options HOT 1
- Add pointer to export database in the export folder
- Add --not-uuid and --not-uuid-from-file HOT 1
- Warning when using --exiftool-merge-keywords and --download-missing
- Add `osxphotos cleanup` command
- KeyError: PLModelVersion HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osxphotos.