Giter Club home page Giter Club logo

Comments (4)

RhetTbull avatar RhetTbull commented on June 5, 2024

May want to also sort PhotoInfo.albums, PhotoInfo.keywords, PhotoInfo.persons, etc.

from osxphotos.

RhetTbull avatar RhetTbull commented on June 5, 2024

Looking at the code I see some values like keywords and labels are sorted but albums are not (though {folder_album} is). All multi-value template values should be sorted.

osxphotos/osxphotos/phototemplate.py

Lines 1213 to 1233 in d81c58f

if field == "album":
values = self.photo.burst_albums if self.photo.burst else self.photo.albums
elif field == "project":
values = [p.title for p in self.photo.project_info]
elif field == "album_project":
values = self.photo.burst_albums if self.photo.burst else self.photo.albums
values += [p.title for p in self.photo.project_info]
elif field == "keyword":
values = sorted(self.photo.keywords) if self.photo.keywords else []
elif field == "person":
values = sorted(self.photo.persons) if self.photo.persons else []
# remove any _UNKNOWN_PERSON values
values = [val for val in values if val != _UNKNOWN_PERSON]
elif field == "label":
values = sorted(self.photo.labels) if self.photo.labels else []
elif field == "label_normalized":
values = (
sorted(self.photo.labels_normalized)
if self.photo.labels_normalized
else []
)

from osxphotos.

RhetTbull avatar RhetTbull commented on June 5, 2024

Working on a fix but this may cause sidecars to be regenerated for those using --sidecar.

from osxphotos.

RhetTbull avatar RhetTbull commented on June 5, 2024

Fixed in v0.66.0

from osxphotos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.