Giter Club home page Giter Club logo

Comments (10)

rherwig avatar rherwig commented on May 20, 2024 1

I tried to implement the version from your current webpack-4 branch and ran into a build-time issue.

I basically set it up like your documentation says, which mainly involves the webpack config:
https://github.com/rherwig/template-react-16-ssr/blob/development/webpack/client.js

Everything but HMR works with mini-extract-css-chunks. If you want to take a look at the issue, please refer to the development branch of this repository :-)

from template-react-ssr.

ScriptedAlchemy avatar ScriptedAlchemy commented on May 20, 2024 1

Found it. Gimme a few

from template-react-ssr.

ScriptedAlchemy avatar ScriptedAlchemy commented on May 20, 2024 1

Fantastic!! More than welcome.

If you have some spare time. Id greatly appreciate it if you can add / extend a test to prevent this happening.

Let me know if you spot anything else

from template-react-ssr.

ScriptedAlchemy avatar ScriptedAlchemy commented on May 20, 2024 1

Aaaaaaand it’s releaeed! V3.x.x is on npm πŸŽ‰πŸŽ‰

from template-react-ssr.

rherwig avatar rherwig commented on May 20, 2024

@zackljackson Thanks a lot! I'll have a look. Would be nice to have working CSS chunks once again :-)

from template-react-ssr.

ScriptedAlchemy avatar ScriptedAlchemy commented on May 20, 2024

It’s already done βœ… just updating readmes and cleaning a bunch of stuff up. Beta testing and feedback would be valuable β€οΈπŸ™ PRs are also welcome if you spot something off the bat

Main thing is I want awesome chunking back πŸ˜‚ its a massive re-rewrite so beta testing is important.

There’s almost half a million installs πŸ˜† safety first

from template-react-ssr.

rherwig avatar rherwig commented on May 20, 2024

I'm taking a look at it right this evening and will of course submit feedback

from template-react-ssr.

zackkirsh avatar zackkirsh commented on May 20, 2024

Awesome, ill be pushing commits throughout the day, just drop a line if you have a question

from template-react-ssr.

ScriptedAlchemy avatar ScriptedAlchemy commented on May 20, 2024

Okay done, should work for you now. Thanks for beta testing! Ill need to write tests for this.

Pretty much it was expecting use: to be an array. Stupid mistake on my part

from template-react-ssr.

rherwig avatar rherwig commented on May 20, 2024

Yay! It works now! :-) Thanks for the effort so far, I'm gonna go on and test it a little more now

from template-react-ssr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.