Non-backwards compatible changes & tagging about rgthree-comfy HOT 7 CLOSED

And 3802964 should fix the issue now. Support for Node Combiner will exist, and a message and a context option to switch to the Collector is now present, for the user to opt-in.

from rgthree-comfy.

Also, it looks like it's leaving behind "ghost" nodes in the workflow for the combiners. My workflow was updated to use the new collectors, but in reviewing the JSON it still has the combiners as well. In addition to that, even though they don't show in the workflow, the workflow fails due to having "missing nodes" for the combiners.

from rgthree-comfy.

Unfortunately, I can’t suppress the error ComfyUI hardcodes, but when the message is closed, everything should still be working as combiners we’re removed and replaced with collectors. Refreshing/saving the updated workflow a second time should no longer show the error message, as it’s been updated.

Was that not working for you? I’ll never purposefully break workflows.

from rgthree-comfy.

I confirm that the last commit broke some workflows.

This one was broken for example : https://civitai.com/models/119528/sdxl-comfyui-ultimate-workflow

I revert to commit d420762 to make it work again.

from rgthree-comfy.

@nicolasSinger what seems to be broken about that workflow? It's not using Combiner/Collector nodes, and seems to load fine for me (though I don't have all the other extension nodes installed as separate issues).

from rgthree-comfy.

Commit c19d219 fixes forward legacy support for Node Combiner. Workflows will no longer auto-update.

Issue mitigated. We'll move forward with a friendlier patch.

from rgthree-comfy.

Just verified with an already updated workflow (using collector) and a non-updated workflow (using combiner). Both are working with the latest commit. In testing upgrading from combiner -> collector (using right click menu), all nodes were able to convert without issue. Thanks for getting this fix out!

from rgthree-comfy.