Giter Club home page Giter Club logo

Comments (8)

derekperkins avatar derekperkins commented on May 18, 2024

It worked just now on a public repo. The original repo I tried it with was a private repo. Will this only work for public repos?

from reviewdog.

haya14busa avatar haya14busa commented on May 18, 2024

Thank you for trying new feature quickly and the quick report.

Hmm... maybe permission setting is wrong?
Do you confirm you installed the private repository to reviewdog app? https://github.com/apps/reviewdog

from reviewdog.

derekperkins avatar derekperkins commented on May 18, 2024

Yes, the private repo is included in the app permissions.

image

from reviewdog.

haya14busa avatar haya14busa commented on May 18, 2024

Oh, i got it. reviewdog github app didn't request "Repository contents" before, but to check the authenticated user have permission to access the repository, reviewdog.app use one GitHub API request to get repository permission status.

I updated permission request of reviewdog app. Can you try again? Maybe you need to ack the new changed permission.

from reviewdog.

derekperkins avatar derekperkins commented on May 18, 2024

I just updated the app with the new permissions, but it didn't change the response. Is it possible that the response is cached somewhere? Do I need to wait a little bit for the settings to propagate?

from reviewdog.

haya14busa avatar haya14busa commented on May 18, 2024

oh, sorry i misunderstood the required permission.
Need to request https://developer.github.com/v3/apps/permissions/#metadata-permissions.

I updated the permission again, so can you try it again?

from reviewdog.

derekperkins avatar derekperkins commented on May 18, 2024

That worked. Thanks! I'm excited to try it out!

from reviewdog.

haya14busa avatar haya14busa commented on May 18, 2024

Cool! Thanks you for the report again :)

from reviewdog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.