Comments (8)
It worked just now on a public repo. The original repo I tried it with was a private repo. Will this only work for public repos?
from reviewdog.
Thank you for trying new feature quickly and the quick report.
Hmm... maybe permission setting is wrong?
Do you confirm you installed the private repository to reviewdog app? https://github.com/apps/reviewdog
from reviewdog.
Yes, the private repo is included in the app permissions.
from reviewdog.
Oh, i got it. reviewdog github app didn't request "Repository contents" before, but to check the authenticated user have permission to access the repository, reviewdog.app use one GitHub API request to get repository permission status.
I updated permission request of reviewdog app. Can you try again? Maybe you need to ack the new changed permission.
from reviewdog.
I just updated the app with the new permissions, but it didn't change the response. Is it possible that the response is cached somewhere? Do I need to wait a little bit for the settings to propagate?
from reviewdog.
oh, sorry i misunderstood the required permission.
Need to request https://developer.github.com/v3/apps/permissions/#metadata-permissions.
I updated the permission again, so can you try it again?
from reviewdog.
That worked. Thanks! I'm excited to try it out!
from reviewdog.
Cool! Thanks you for the report again :)
from reviewdog.
Related Issues (20)
- Error while running reviewdog with rdjson and github-check reporter HOT 1
- Error while running reviewdog with rdjson and github-check reporter HOT 1
- GitHub Action does not work while running reviewdog with rdjson and github-pr-review reporter HOT 1
- fail-on-error=false (or left on default) still exits 1 using Github checks
- `-fail-on-error` doesn't work. reviewdog returns zero as exit code even if warnings are found in input HOT 4
- Does not use REVIEWDOG_GITHUB_API_TOKEN unless REVIEWDOG_SKIP_DOGHOUSE is set
- Can not Work HOT 1
- reviewdog: failed to get merge-base commit: exit status 1 HOT 2
- Tfsec- parse error: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token HOT 2
- 0.15.0 installation fails on Alpine using `go get` HOT 1
- Support --filter-mode=[file/nofilter] in github-pr-review
- Can I use XO with review dog?
- `action-flake8` is broken due to an update in `astroid` HOT 1
- 'github-pr-review' reporter is not making suggestion for blank line addition
- Support for Vale text linter HOT 2
- Bundle related suggestions together
- [BUG] Sarif format not working HOT 9
- fail to run reviewdog: XML syntax error on line 10: expected attribute name in element HOT 1
- 'reviewdog: .git exist but is not a directory' in submodule
- Add support for Azure Devops
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reviewdog.