Giter Club home page Giter Club logo

Comments (3)

Flamefire avatar Flamefire commented on June 15, 2024

Can't we just distribute the patched map files? Not sure if allowing file modifications from Lua is a good idea...

from s25client.

Spikeone avatar Spikeone commented on June 15, 2024

Well, @Flow86 asked @ottml to remove the patched map files in some PR - thats where this patch idea is from. I'm fine with distributing the changed original files, but not sure if we are allowed to do so.

I think it's safe to change the files after they have been loaded, but not on the harddrive.

from s25client.

Spikeone avatar Spikeone commented on June 15, 2024

@Flow86 @Flamefire since the PR #1628 might be merged soon, we should decide on this one. At least two of the LUA scripts included will not work correctly. On the first map 7 players are loaded by rttr but 6 have invalid positions, I think on the sixth map, one player position is invalid, thus the game doesn't start.
I'd personally just include the files, but not sure if we are legally allowed. But finally having the campaign screen with the original campaign but with 2 maps not working doesn't feel right regarding user expectation :-/

from s25client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.