Comments (3)
Can't we just distribute the patched map files? Not sure if allowing file modifications from Lua is a good idea...
from s25client.
Well, @Flow86 asked @ottml to remove the patched map files in some PR - thats where this patch idea is from. I'm fine with distributing the changed original files, but not sure if we are allowed to do so.
I think it's safe to change the files after they have been loaded, but not on the harddrive.
from s25client.
@Flow86 @Flamefire since the PR #1628 might be merged soon, we should decide on this one. At least two of the LUA scripts included will not work correctly. On the first map 7 players are loaded by rttr but 6 have invalid positions, I think on the sixth map, one player position is invalid, thus the game doesn't start.
I'd personally just include the files, but not sure if we are legally allowed. But finally having the campaign screen with the original campaign but with 2 maps not working doesn't feel right regarding user expectation :-/
from s25client.
Related Issues (20)
- Wiki Linux Install Guide missing libsdl2-mixer-2.0-0 HOT 3
- [RFC] Layout helper classes HOT 2
- Status of WinAPI backend and querying capabilities HOT 2
- Issue opening game on macOS 3/4 of window is red HOT 22
- Boats row ashore if there is a warehouse HOT 5
- Cannot start map "The Snake" HOT 2
- Trouble building s25client on Mac HOT 2
- IPv6 Hosting is not working correctly
- Automatic activity window placement not working as expected
- Window snapping is 2 pixel off
- Crash in Replay (which has also been ingame)
- Ready to use Slovakian, Czech and Polish fonts HOT 1
- path and filenames for lua files are case sensitive HOT 2
- [Campaign] Can not set maptitle HOT 2
- Add support for campaign status HOT 9
- can no longer start on Osx High Sierra 10.13.6 (17G14042) HOT 2
- Audio driver not loaded on OSX 14.2.1
- Integrate optional upscaling model HOT 2
- No sound with pipewire HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from s25client.