Giter Club home page Giter Club logo

Comments (6)

RyanFarley avatar RyanFarley commented on July 21, 2024

I added UserAgent to my fork, but I only added it to the RestClient, not the RestRequest. What would a use-case be for overriding it for a particular request?

from restsharp.

mstum avatar mstum commented on July 21, 2024

Haven't seen a case for it TBH. I could imagine some test application impersonating different clients/bots, but I think that's a rather small use case. Did you change the _restrictedHeaderActions in Http.cs to throw away the user-agent if set as a Header-parameter? If not, that would give users the option to override it anyway without the need to have an overly visible property on the RestRequest that could confuse people.

Should there be a default User-Agent ("RestSharp 1.x.x.x") or would that be to obnoxious?

from restsharp.

johnsheehan avatar johnsheehan commented on July 21, 2024

I don't mind a default. I've run into APIs that will reject requests if there isn't one so it's probably good to have a default.

from restsharp.

RyanFarley avatar RyanFarley commented on July 21, 2024

I added this

from restsharp.

johnsheehan avatar johnsheehan commented on July 21, 2024

thanks!

from restsharp.

mstum avatar mstum commented on July 21, 2024

Awesome, Thanks!

from restsharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.