Comments (2)
I am experiencing a similar issue, where the check for req.useChunkedEncodingByDefault is preventing socket reuse for a persistent connection that I need for a series of POST requests.
I'm currently getting past the problem by checking req.chunkedEncoding instead. Here is the change to index.js:
@@ -48,7 +48,7 @@
ForeverAgent.prototype.addRequestNoreuse = Agent.prototype.addRequest
ForeverAgent.prototype.addRequest = function(req, host, port) {
var name = host + ':' + port
- if (this.freeSockets[name] && this.freeSockets[name].length > 0 && !req.useChunkedEncodingByDefault) {
+ if (this.freeSockets[name] && this.freeSockets[name].length > 0 && !req.chunkedEncoding) {
var idleSocket = this.freeSockets[name].pop()
idleSocket.removeListener('error', idleSocket._onIdleError)
delete idleSocket._onIdleError
from forever-agent.
Pull request #29 Enable socket reuse, is the proposal to resolve this issue.
from forever-agent.
Related Issues (20)
- Too much intimacy between this, request, and http.Agent HOT 4
- socket.setTimeout for foreverAgent HOT 2
- Add `tls` as depedency HOT 4
- check for req.chunkedEncoding rather than req.useChunkedEncodingByDefault HOT 1
- add property 'protocol' to make it work under node 0.11
- MIT license HOT 1
- Create tests
- how do I use this?
- there is zero documentation HOT 2
- add agent.destroy HOT 2
- Module intention clarification
- Crash after trying to debug application using orientjs module
- bug in getConnectionName HOT 1
- Error EONT when using ForeverAgent HOT 1
- how can we use this module with https://github.com/request/request HOT 1
- Publish new version
- forever-agent.getConnectionName() is different with _http_agent.getName() HOT 1
- The Copyright phrase is missing. HOT 1
- keep alive in POST request
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forever-agent.