Comments (7)
tedepstein
commented on August 22, 2024
To clarify: validation errors in the Swagger Spec should not result in a modal dialog appearing when we the user opens the file. The fact that the same error is reported twice in the dialog box is just another, smaller issue. The main issue is, we should not have this kind of exception reporting when trying to open a file.
from kaizen-openapi-editor.
ghillairet
commented on August 22, 2024
I think this has to do with the introduction of live validation (see #38), error markers are not reset when file is reopen.
from kaizen-openapi-editor.
tfesenko
commented on August 22, 2024
I was able to reproduce this issue too on the latest RepreZen master build (RepreZen+SwagEdit integration).
The dialog is not shown when you create the error in the editor (I just pasted the code), but it appears when you close and open the SwagEdit editor.
from kaizen-openapi-editor.
ghillairet
commented on August 22, 2024
I don't have any dialog box showing up when reopening the file, and don't have the same error twice, but 2 different errors.
from kaizen-openapi-editor.
tfesenko
commented on August 22, 2024
@ghillairet , I reproduced it on a RepreZen build with SwagEdit integration, e.g. http://products.modelsolv.com:8111/repository/download/bt5/6113:id/product/com.modelsolv.reprezen.product-macosx.cocoa.x86_64.zip . Can you please try it on this build? If you still don't see an error box I can show it to you at tomorrow's call.
from kaizen-openapi-editor.
ghillairet
commented on August 22, 2024
If you look at the log, looks like the error is not catch by the swagedit live plugin in class SwagEditorSource (line 233).
Caused by: mapping values are not allowed here
in 'reader', line 23, column 18:
in: query
^
at com.fasterxml.jackson.dataformat.yaml.snakeyaml.scanner.ScannerImpl.fetchValue(ScannerImpl.java:871)
at com.fasterxml.jackson.dataformat.yaml.snakeyaml.scanner.ScannerImpl.fetchMoreTokens(ScannerImpl.java:360)
at com.fasterxml.jackson.dataformat.yaml.snakeyaml.scanner.ScannerImpl.checkToken(ScannerImpl.java:226)
at com.fasterxml.jackson.dataformat.yaml.snakeyaml.parser.ParserImpl$ParseBlockMappingKey.produce(ParserImpl.java:558)
at com.fasterxml.jackson.dataformat.yaml.snakeyaml.parser.ParserImpl.peekEvent(ParserImpl.java:158)
at com.fasterxml.jackson.dataformat.yaml.snakeyaml.parser.ParserImpl.getEvent(ParserImpl.java:168)
at com.fasterxml.jackson.dataformat.yaml.YAMLParser.nextToken(YAMLParser.java:331)
at com.fasterxml.jackson.databind.deser.std.BaseNodeDeserializer.deserializeObject(JsonNodeDeserializer.java:218)
at com.fasterxml.jackson.databind.deser.std.BaseNodeDeserializer.deserializeArray(JsonNodeDeserializer.java:267)
at com.fasterxml.jackson.databind.deser.std.BaseNodeDeserializer.deserializeObject(JsonNodeDeserializer.java:227)
at com.fasterxml.jackson.databind.deser.std.BaseNodeDeserializer.deserializeObject(JsonNodeDeserializer.java:224)
at com.fasterxml.jackson.databind.deser.std.BaseNodeDeserializer.deserializeObject(JsonNodeDeserializer.java:224)
at com.fasterxml.jackson.databind.deser.std.BaseNodeDeserializer.deserializeObject(JsonNodeDeserializer.java:224)
at com.fasterxml.jackson.databind.deser.std.JsonNodeDeserializer.deserialize(JsonNodeDeserializer.java:62)
at com.fasterxml.jackson.databind.deser.std.JsonNodeDeserializer.deserialize(JsonNodeDeserializer.java:14)
at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:3562)
at com.fasterxml.jackson.databind.ObjectMapper.readTree(ObjectMapper.java:2136)
at com.modelsolv.reprezen.swagedit.live.SwagEditorSource$SwagEditorState.getSwaggerJson(SwagEditorSource.java:233)
at com.modelsolv.reprezen.swagedit.live.SwagEditorSource$SwagEditorState.hasErrors(SwagEditorSource.java:226)
at com.modelsolv.reprezen.gentemplates.common.ui.view.BrowserViewPage.sourceChanged(BrowserViewPage.java:307)
at com.modelsolv.reprezen.swagedit.live.SwagEditorSource$DocumentIdleListenerAdapter.editorIdle(SwagEditorSource.java:151)
at org.dadacoalition.yedit.editor.IdleTimer$2.run(IdleTimer.java:147)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
... 23 more
from kaizen-openapi-editor.
tedepstein
commented on August 22, 2024
Fix in RepreZen PR 813 has passed QA.
from kaizen-openapi-editor.
Related Issues (20)
- Failure running with java 11 HOT 2
- Code assist is missing properties named "default"
- Skip empty strings in formatter (customizable)
- File does not contain a valid swagger spec HOT 2
- Plugin not compatible with Eclipse 2019-06 release? HOT 3
- Memory leak in swagger editor
- YAML References in other files throws warning
- Internal error occurred during: "Update KaiZen Editor validation markers" HOT 4
- Only Swagger v2 features work, not OpenAPI v3 HOT 7
- Error updating Kaizen Editor to version 0.8.0.201909121743 HOT 3
- Unable to close eclipse properly because of Kaizen-OpenAPI-Editor HOT 1
- invalid character in reference
- Spell checker is not working on Swagger file editor HOT 1
- Add "./" for file completion on file $ref
- Doesn't follow the Eclipse Color Theme plugin (so black text on black background is a result of dark theme) HOT 3
- Installation in 2020-12 fails silently
- Avoid warning on inherited properties (allOf)
- description causes failed to match exactly one schema
- Update site returning HTTP status 504 HOT 5
- Update Site is down HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kaizen-openapi-editor.