Comments (10)
In API Studio, we are using the Eclipse Color Theme plugin, with a dark color theme (inkpot) selected. For general use outside of API studio, we probably should not assume a dark background, so we should choose colors that works with a light background.
from kaizen-openapi-editor.
Note that eclipse color theme plugins requires that mappings for specific editors are contributed (see https://github.com/eclipse-color-theme/eclipse-color-theme/wiki/Contributing). The mapping for YEdit is already present in the current version of eclipsecolortheme, that explains why SwagEdit works well with it.
Also the general use of this color theme plugin is that users choose a theme and then all their editors use that particular theme.
The default theme from Eclipse is the one with white background and purple color for keywords (see Java editor for ex). Maybe this one should be use.
from kaizen-openapi-editor.
@ghillairet , can you paste a screenshot with SwagEdit in the default theme?
from kaizen-openapi-editor.
So the default theme for YEdit does not use similar colors as the Eclipse default. Choosing Default theme in eclipse color themes preferences makes editors use their defaults preferences.
Looks like this for YEdit (and SwagEdit)
I was thinking we could provide default preferences that would look like that
from kaizen-openapi-editor.
Yes, I think that second screenshot looks good. Let's go with that color scheme as the default.
from kaizen-openapi-editor.
After having merged the PR, I noticed that what I see is slightly different from the screenshot above:
Note that boolean values ("Constants") are blue in my screenshot, but they are green on Guillaume's.
from kaizen-openapi-editor.
@ghillairet , it also looks to me like the purple/violet color is not the same as in your screenshot. Can we make the default colors match your earlier sceenshot?
from kaizen-openapi-editor.
I took the colors from the default Java editor, in the first screenshot I took colors that look like it.
Here what it looks like on my screen.
from kaizen-openapi-editor.
For info, default colors for SwagEdit are defined here https://github.com/ModelSolv/SwagEdit/blob/master/com.reprezen.swagedit/src/com/reprezen/swagedit/preferences/SwaggerPreferenceInitializer.java#L21
from kaizen-openapi-editor.
I confirmed that the purple color matches Eclipse's default for Java keywords. Boolean constants are blue, also apparently consistent with Java's color scheme.
@tfesenko , I'm satisfied with these colors. If you approve, please close this.
from kaizen-openapi-editor.
Related Issues (20)
- Failure running with java 11 HOT 2
- Code assist is missing properties named "default"
- Skip empty strings in formatter (customizable)
- File does not contain a valid swagger spec HOT 2
- Plugin not compatible with Eclipse 2019-06 release? HOT 3
- Memory leak in swagger editor
- YAML References in other files throws warning
- Internal error occurred during: "Update KaiZen Editor validation markers" HOT 4
- Only Swagger v2 features work, not OpenAPI v3 HOT 7
- Error updating Kaizen Editor to version 0.8.0.201909121743 HOT 3
- Unable to close eclipse properly because of Kaizen-OpenAPI-Editor HOT 1
- invalid character in reference
- Spell checker is not working on Swagger file editor HOT 1
- Add "./" for file completion on file $ref
- Doesn't follow the Eclipse Color Theme plugin (so black text on black background is a result of dark theme) HOT 3
- Installation in 2020-12 fails silently
- Avoid warning on inherited properties (allOf)
- description causes failed to match exactly one schema
- Update site returning HTTP status 504 HOT 5
- Update Site is down HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kaizen-openapi-editor.