Upgrade to php 7.3.11 breaks Reportico 4.6 about reportico HOT 5 OPEN

Correction:
CSV export still works.

from reportico.

function abs_paging_height($height_string)
{
	$height = (int)$height_string;
	if ( strstr($height_string, "%" ) )
	{
		$height = (int)

--------------------This is the problem on line 151 --------
( $this->page_height * $height_string ) / 100;
}

	return $height;
}

from reportico.

Error thrown on pdf export:

/nfs/c10/h05/mnt/144724/domains/test.airheads.org/html/components/com_reportico/tcpdf/tcpdf.php Line 18021 - "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?
Main Report Query - Error: Query Failed

SELECT s.state, v3.field_value as region, s.membership_id, s.first_name, s.last_name, s.city, s.zip, s.country, s.phone, s.email, v1.field_value, v2.field_value FROM j17_osmembership_subscribers=s LEFT JOIN j17_osmembership_field_value as v1 on (s.id=v1.subscriber_id and v1.field_id=21) LEFT JOIN j17_osmembership_field_value as v2 on (s.id=v2.subscriber_id and v2.field_id=30) LEFT JOIN j17_osmembership_field_value as v3 on (s.id=v3.subscriber_id and v3.field_id=31) WHERE 1=1 -- AND s.plan_id=5 AND v1.field_value="airmarshal" AND is_profile=1 -- AND plan_main_record=1 -- AND s.published=1 ORDER BY s.country DESC, s.state ASC

Status 0 -

from reportico.

Hi there

Thanks for the info.. i certainly need to check the module for this release..

Have you manage to change the files your self so it works?
I can look tomorrow to provide you fixes but

certainly editing /nfs/c10/h05/mnt/144724/domains/test.airheads.org/html/components/com_reportico/tcpdf/tcpdf.php Line 18021 and changing

continue; 

to

continue 2;

should work.. also the fix for reportico_report_html.php is to change the line

from

if ( strstr($height_string, "%" ) ) 

to

if ($this->page_height && strstr($height_string, "%")) 

Let me know if you want me to provide replacement files

Peter

from reportico.

Thank you Peter for such a fast response !
That did fix the problem.

Cheers !

from reportico.