Giter Club home page Giter Club logo

Comments (8)

ewnd9 avatar ewnd9 commented on June 19, 2024

The reason behind the error is due to deprecation of short loader syntax (should be script-loader in webpack@2)

However, after I manually changed that, I see the following

image

I suggest starting with the browser example from this repo and gradually add dependencies/config from ejected create-react-app to find what's wrong.

from anki-apkg-export.

yakhinvadim avatar yakhinvadim commented on June 19, 2024

Thanks for the help. I'll try to fix it and send a PR.

from anki-apkg-export.

yakhinvadim avatar yakhinvadim commented on June 19, 2024

For some reason, there are several very similar "filesaver" packages on npm (in order of popularity)

You are using the third one and it works fine for your cases, but its readme says to use the first. I installed it and my error has gone :)

I tried the most popular package with your examples and it doesn't work correctly for browser-media-file-input (card doesn't have the image from input). I've sent you a PR #23, where I switched the filesaverjs for file-saver, so if you wanted to, you could investigate why it doesn't work as expected. But it breaks your examples, so it's ok if you decline it.

I've also sent a PR #22, which fixes short-loader syntax.

from anki-apkg-export.

ewnd9 avatar ewnd9 commented on June 19, 2024

Yeah, I've seen deprecation messages from filesaver when tried your create-react-app example, but didn't have time to check.

I installed it and my error has gone :)

You are talking about the deprecate error in #19 (comment) right?

I'm going to investigate the package from your pr later, thanks for help 👍

from anki-apkg-export.

yakhinvadim avatar yakhinvadim commented on June 19, 2024

You are talking about the deprecate error in #19 (comment) right?

Sorry, I wasn't clear. Yes, I was talking about deprecate error.

from anki-apkg-export.

ewnd9 avatar ewnd9 commented on June 19, 2024

Apparently the most popular filesaver wasn't on npm at the time I published the first version (package.json only added in May 26, 2016 eligrey/FileSaver.js@cb8e076)

from anki-apkg-export.

ewnd9 avatar ewnd9 commented on June 19, 2024

I've checked locally your branch and turned out you forgot to rebase with my latest changes, the error in examples was due to very old anki-apkg-export dependency, see cc9d686

Thanks again, not only the package now is future-proof, but I also gained the knowledge about non-obvious (for me) deprecating behavior in some environments, appreciate that ✌️


I've published v3.2.0, let me know if it works ok for your project.

from anki-apkg-export.

yakhinvadim avatar yakhinvadim commented on June 19, 2024

Everything's ok now, thanks!

from anki-apkg-export.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.