Comments cause entire line to be dropped about strip-markdown HOT 5 CLOSED

Ah, sorry, meant to close this myself :)

Cheers!

from strip-markdown.

Thanks for raising this issue!

The problem here arises because an HTML comment at the start of the line “taints” the whole paragraphs as HTML. As an example, I pasted this code:

<!--A comment-->, **importance**, and `code`.

Below:

As you can see, the importance (bold) and code no longer “work”.

A solution would be to not start the line with HTML:

A <!--comment-->, **importance**, and `code`.

Yields:

A , importance, and code.

...and otherwise I wouldn’t really know how to do this in markdown (HTML in markdown is horrible and breaks lots of things). But you could transform the markdown/HTML to HTML first (with remark-rehype and rehype-raw) and then strip all tags?

from strip-markdown.

@wooorm cool, makes sense. This was mostly just a corner case for processing user input, so I think I'll just throw an error if people write this. Thanks for the suggestion though :-)

Am I correct in thinking that we should leave this open, though, since it seems to be a legitimate bug?

from strip-markdown.

Sorry for the slightly late response!

Am I correct in thinking that we should leave this open, though, since it seems to be a legitimate bug?

I dunno, I don’t think this can ever be “fixed”. Other vendors (e.g., markdown-it without html enabled) handle this similar...

from strip-markdown.

As this is handled similarly by other markdown parsers (commonmark, markdown-it, gfm), I’d say this is working as it’s supposed to!

from strip-markdown.