Giter Club home page Giter Club logo

Comments (4)

wooorm avatar wooorm commented on May 18, 2024

Well, yes. That would break every plugin out there :) In addition, though I like the concept of immutability, this is how ware (which is used internally), koa, and express also use.

Also, it is impossible with the current set-up, through the previously mentioned ware, to add this, because it doesn’t support return values (P.S. transformers can be async)

In addition, often, plug-ins only make small changes. Adding a few attributes, &c. Wouldn’t it be very expensive in performance to have to clone the AST each time?

from remark.

dthree avatar dthree commented on May 18, 2024

Okay fine I see where you're coming from :)

Maybe just a doc update that clearly explains that's what is happening would suffice. The main point is predictability, so if its clear that shouldn't be a problem IMHO.

from remark.

wooorm avatar wooorm commented on May 18, 2024

Tsk, a comma separated close doesn’t work 😦...

Anyway, I think that 8664a03 closes this because it clearly shows that no AST is returned. Do you agree? If not, please re-open and let me know where you’d like this notice!

from remark.

dthree avatar dthree commented on May 18, 2024

Looks good! Thanks!

from remark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.