Comments (11)
sibelius
commented on July 24, 2024
Can you provide more info? In which version?
from relay-compiler-language-typescript.
steida
commented on July 24, 2024
In master:
from relay-compiler-language-typescript.
sibelius
commented on July 24, 2024
it should be easy to get this working
https://github.com/facebook/relay/search?q=noFutureProofEnums&unscoped_q=noFutureProofEnums
from relay-compiler-language-typescript.
alloy
commented on July 24, 2024
Ah good catch! Yeah, like @sibelius says, a PR for this should be simple enough and would be much appreciated.
from relay-compiler-language-typescript.
artola
commented on July 24, 2024
This is the upstream PR introducing the flag:
from relay-compiler-language-typescript.
artola
commented on July 24, 2024
@steida are you interested to port this code?
from relay-compiler-language-typescript.
sibelius
commented on July 24, 2024
sure
does doing this
if (!noFutureProofEnums) {
values.push('%future added value');
}would be enough
from relay-compiler-language-typescript.
artola
commented on July 24, 2024
@sibelius might be a bit more ... as shown in the upstream.
noFutureProofEnums:
- https://github.com/facebook/relay/blob/f54557df14f992ce175153913736eed3e2419d7c/packages/relay-compiler/language/javascript/RelayFlowGenerator.js#L260
-https://github.com/facebook/relay/blob/f54557df14f992ce175153913736eed3e2419d7c/packages/relay-compiler/language/javascript/RelayFlowGenerator.js#L523
should not be more than 3-4 small blocks.
from relay-compiler-language-typescript.
sibelius
commented on July 24, 2024
Feel free to contribute
from relay-compiler-language-typescript.
artola
commented on July 24, 2024
from relay-compiler-language-typescript.
alloy
commented on July 24, 2024
👍
from relay-compiler-language-typescript.
Related Issues (20)
- Generated refetch definition with variables can not pass the validation of backend, such as github.com/vektah/gqlparser/v2
- Generate GraphQL fragment files for VSCode GraphQL Extension fragment autocompletion HOT 2
- Cannot read property 'createKeywordTypeNode' of undefined HOT 8
- Support for [email protected] HOT 8
- Migrate travis CI release process to GitHub actions HOT 3
- Unknown directive 'appendNode' HOT 1
- module esnext HOT 2
- Why is it not releasing HOT 7
- `require` substitution is not working HOT 6
- doc: explain why configuration with a single artifact directory is suggested
- Update to TS 4.4 and update types to support exactOptionalPropertyTypes HOT 1
- @stream argument naming by schema spec is: `initialCount` not `initial_count` HOT 1
- Invalid AST Node error with graphql@16 HOT 2
- Typescript 4.5 type generation is broken HOT 6
- Relay Compiler generates Typescript Synthax error HOT 3
- Error: Cannot find module 'relay-compiler-language-typescript' on 15.0
- Fragment Typematching
- Input Types generated as readonly HOT 1
- deprecate this package HOT 1
- Issue with import of the __generated__
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from relay-compiler-language-typescript.