Support Relay v2.0.0 about relay-compiler-language-typescript HOT 4 CLOSED

That renaming of inputFieldWhiteList to optionalInputFields looks good to me, care to make a PR?

As for the second issue, that seems a bit more suspect to me. Could you try to reproduce it by upgrading the example app in this repo to 1.7.0?

from relay-compiler-language-typescript.

I'm fine with making a PR. Couple questions:

• Would you want it to be backwards compatible?

It would look like

const props = Object.keys(fields)
  .map(key => fields[key])
  .filter(
    field =>
      // Relay 1.6.2 and below
      (state.inputFieldWhiteList &&
        state.inputFieldWhiteList.indexOf(field.name) < 0) ||
      // Relay 1.7.0
      (state.optionalInputFields &&
        state.optionalInputFields.indexOf(field.name) < 0),
  );

• Is adding optionalInputField as an optional type and making inputFieldWhiteList an optional type ok?

I'll get back to you with a reproduction repo.

from relay-compiler-language-typescript.

@johntran Idk about @alloy - but personally I don't see the need to make it backwards compatible. Relay does not officially support this plugin before v1.7.x - it was only supported through a fork that @alloy has maintained. I do think we need to worry as much as possible about backwards compatibility going forward though.

from relay-compiler-language-typescript.

Due to other reasons upgrading to the latest relay isn’t trivial for us, but until any other new features/big fixes would be added there’s also no real reason for us to upgrade the plugin, so I’m fine with no backwards compatibility for this change 👍

from relay-compiler-language-typescript.