Emitted types break default setup when colocating artefacts. about relay-compiler-language-typescript HOT 6 CLOSED

I just edited in my thoughts as you replied, realised it might not be obvious why it would be a good idea.

from relay-compiler-language-typescript.

I see now.

This does indeed seem quite weird. I think there's still value in emitting the types (just as flow does) but emit those as any as well (ie. not as a unique symbol type).

Ie. for the above linked playground we should emit something like this instead

EDIT:

The value we gain is that it allows people to use Relay with typescript without having to typecast to any when rendering the components, as the typings inside the react-relay package will now simply mark that the property value doesn't matter, but still transform the prop types.

from relay-compiler-language-typescript.

Fair, we could do that too. What’s your thought for there still being value? Just as a named label that could help indicate what reference is required?

from relay-compiler-language-typescript.

@ckknight Are you perchance interested in submitting a PR for that? The type generator receives a flag that indicates wether or not the single artefact directory feature is enabled.

Having said all that, and we absolutely should not break the default setup, I would suggest you consider enabling the single artefact directory feature after all, as it’s the only stable simple way we could come up with that would allow you to have typed fragment references without using the Haste module system.

from relay-compiler-language-typescript.

To be honest I would not be too surprised if using the single artifact directory ends out being the way most people will use relay going forward (either that or we get some nifty way of tracking where the artifacts are being output in the future such that we can get around the issues we're circumventing by using this feature). It helps both Flow and TypeScript users get the typechecking features they deserve.

With that said - making the changes stated here makes sense, it will help us reach parity with the Flow implementation.

from relay-compiler-language-typescript.

Agreed. facebook/relay#2509

from relay-compiler-language-typescript.