Support --noImplicitAny about relay-compiler-language-typescript HOT 11 CLOSED

It should be possible to use the TypeScript parser / emitter to inject the needed type annotations - although if you haven't used this API before it might be a bit tricky. I don't think it will be that costly using the TS API for this, it should be kinda fast - but obviously this would need to be verified.

from relay-compiler-language-typescript.

@alloy sounds good! I'm travelling this week but will get started on the PR after

from relay-compiler-language-typescript.

This makes sense, yeah, send a PR 👍

from relay-compiler-language-typescript.

I tried and I don't understand it quiet yet.. any hints to help me out?

from relay-compiler-language-typescript.

Hmm, yeah, this isn’t that easy right now. The plugin currently only operates on the types for the resulting GraphQL selections, not the artefact AST. The artefact AST comes in as just a large string from relay-compiler here, so the only way I could currently see this work is if we were to parse that text and regenerate it with the any typings, but that seems a little costly. Maybe we can determine if the noImplicitAny compiler flag is enabled and only then do the parsing/regeneration?

In any case, that’s where you should start with this.

from relay-compiler-language-typescript.

I hacked it together today.

function addAsAnyToObjectLiterals(oldSource){
    const ts = require("typescript");

    function transformer(context){
        return function transform(node){
            function visit(node){
                if(node.kind === ts.SyntaxKind.ObjectLiteralExpression){
                    return ts.createAsExpression(node, ts.createTypeReferenceNode('any', []));
                }
                return ts.visitEachChild(node, visit, context);
            }
            return ts.visitNode(node, visit);
        }   
    }

    const source  = ts.createSourceFile('', oldSource);

    const result = ts.transform(source, [transformer]);

    const printer = ts.createPrinter();
    const newSource = printer.printFile(result.transformed[0]);
    return newSource;
}

from relay-compiler-language-typescript.

Nice and simple 👌 And where are you adding this into your pipeline?

from relay-compiler-language-typescript.

should this be an option for relay compiler?

from relay-compiler-language-typescript.

@alloy I manually added it here in my project and it worked. If you want I can look into integrating it into this library.

from relay-compiler-language-typescript.

@sibelius I don’t think so, it’s a project wide TS setting, so my opinion is that we should fetch it from the project’s tsconfig (or perhaps there’s a runtime test for tsc options.)

@timjacobi Yeah that would be much appreciated! (And only do so when the option is enabled, as per above.)

from relay-compiler-language-typescript.

Closed by #83

from relay-compiler-language-typescript.