Make nullable fields on input types optional about relay-compiler-language-typescript HOT 5 CLOSED

Fixed in #47

from relay-compiler-language-typescript.

AFAIK this logic has been ported directly from the Flow type generator. I hear what you’re saying, but I’d prefer that this would be discussed upstream first and see if the Relay team had a specific reason in mind for designing it this way. Could you please file a ticket in the Relay repo with an example of what you’d like to see changed for discussion and link it here?

from relay-compiler-language-typescript.

I just ran the alloy's 1.5.0-plugin.5 build of the compiler without the language flag and the flow types are using mabye types and optional properties which would be equivalent to a nullable, optional property in typescript

This was copied directly from the output

export type SqlString = {
  eq?: ?string,
  ne?: ?string,
  like?: ?string,
  notLike?: ?string,
};

And this is what --language typescript kicks out

export type matterQueryVariables = {
    readonly matterId: {
        readonly eq: string | null;
        readonly ne: string | null;
        readonly like: string | null;
        readonly notLike: string | null;
    };
};

from relay-compiler-language-typescript.

Aha, so we did indeed not port that fully. Good catch and thanks for the details!

from relay-compiler-language-typescript.

Finally merged.

from relay-compiler-language-typescript.