Giter Club home page Giter Club logo

Comments (10)

alloy avatar alloy commented on July 4, 2024

Oh great question! Actually the way I’ve been using it, due to various transitive dependencies that really should all be using the same versions, is by using yarn’s resolutions feature, which is also how it’s being used in the example app’s setup.

Hope that helps!

from relay-compiler-language-typescript.

arieldf avatar arieldf commented on July 4, 2024

@alloy Great! Thanks - I did not understand the resolutions correctly. Thanks again for the great efforts here

from relay-compiler-language-typescript.

alloy avatar alloy commented on July 4, 2024

Thanks for testing and please give us any feedback on the PR whilst things have not been merged yet!

from relay-compiler-language-typescript.

arieldf avatar arieldf commented on July 4, 2024

@alloy So far things are working nice! I do get the errors below when starting the app, but things seem to work as expected.

ERROR in project/packages/modules/example/ts/app.tsx(74,25):
TS2322: Type '{ viewer: any; }' is not assignable to type 'IntrinsicAttributes & Props & { children?: ReactNode; }'.
Type '{ viewer: any; }' is not assignable to type 'Props'.
Property 'relay' is missing in type '{ viewer: any; }'.
ERROR in project/packages/modules/example/ts/components/TodoApp.tsx(56,21):
TS2322: Type '{ viewer: TodoApp_viewer; }' is not assignable to type 'IntrinsicAttributes & Props & { children?: ReactNode; }'.
Type '{ viewer: TodoApp_viewer; }' is not assignable to type 'Props'.
Property 'relay' is missing in type '{ viewer: TodoApp_viewer; }'.
ERROR in project/packages/modules/example/ts/components/TodoApp.tsx(57,40):
TS2322: Type '{ viewer: TodoApp_viewer; }' is not assignable to type 'IntrinsicAttributes & Props & { children?: ReactNode; }'.
Type '{ viewer: TodoApp_viewer; }' is not assignable to type 'Props'.
Property 'relay' is missing in type '{ viewer: TodoApp_viewer; }'.
ERROR in project/packages/modules/example/ts/components/TodoList.tsx(49,9):
TS2322: Type '{ key: string; todo: { readonly id: string; readonly complete: boolean | null; }; viewer: TodoLis...' is not assignable to type 'IntrinsicAttributes & Props & { children?: ReactNode; }'.
Type '{ key: string; todo: { readonly id: string; readonly complete: boolean | null; }; viewer: TodoLis...' is not assignable to type 'Props'.
Property 'relay' is missing in type '{ key: string; todo: { readonly id: string; readonly complete: boolean | null; }; viewer: TodoLis...'.
Version: typescript 2.6.2

from relay-compiler-language-typescript.

alloy avatar alloy commented on July 4, 2024

Are you using the latest versions of the @types/react-relay and @types/relay-runtime packages?

from relay-compiler-language-typescript.

alloy avatar alloy commented on July 4, 2024

Or can you otherwise include a failing code snippet?

from relay-compiler-language-typescript.

arieldf avatar arieldf commented on July 4, 2024

@alloy, so this turned out to be a clash with typings. I removed the relay-runtime and react-relay types and it works (I am using latests React).

from relay-compiler-language-typescript.

alloy avatar alloy commented on July 4, 2024

Did you remove them completely? Or did you remove the clashing ones?

from relay-compiler-language-typescript.

arieldf avatar arieldf commented on July 4, 2024

I removed the types for relay-runtime and react-relay and it is working nicely. Would be nice to have the types, but in my case I am fine without.

from relay-compiler-language-typescript.

alloy avatar alloy commented on July 4, 2024

The typings should be working, though, it does for us at least and otherwise it’s a bug. Could you try to create a minimal example project that exhibits the problem?

from relay-compiler-language-typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.