Comments (6)
Some further thoughts. I've been thinking about the name gorums.qc_future
. I think we should rename it to gorums.async
, since that has become the de facto naming for such call semantics, even though it isn't exactly the async/await semantics of some languages. Thoughts? @tormoder @leandernikolaus @Raytar
from gorums.
Some further thoughts. I've been thinking about the name
gorums.qc_future
. I think we should rename it togorums.async
, since that has become the de facto naming for such call semantics, even though it isn't exactly the async/await semantics of some languages. Thoughts? @tormoder @leandernikolaus @Raytar
Is the idea still to make it work like the ordered option, such that you specify gorums.quorumcall
and gorums.async
? In that case, does it make sense to use it with any other call types? Can a correctable
be async?
from gorums.
This is the question. I'm considering whether or not it makes sense to use async
as a secondary option to quorumcall
. Not sure it makes sense to use it along with the other call types, such as correctable
, since correctable variants follow a similar design as that of async
. To that end, maybe the correctable variants are really sub types of async
. But there are essentially three variants:
- async (currently qc_future)
- correctable
- correctable_stream (currently this only requires correctable along with the rpc method being server streaming.)
from gorums.
(It's been a long time and I don't have the bandwidth to look at the details).
future/async
for quorumcall
was, as I remember it, just a "programming feature" to make the client able to execute quorum call asynchronously in code. It was really more of a convenience feature, and clients could write the wrapper themselves. I.e. it is not a "property" of the underlying call.
A correctable
is inherently async
, since a client may get an initial result, but the result may be updated several times asynchronously and concurrently with the client using the initial reply.
from gorums.
Below is one idea for the option combinations that we can support. It feels a bit unnatural to require async
together with correctable
.
What do you think?
Anyone have better ideas?? @tormoder @leandernikolaus @Raytar
// New ordered synchronous RPC call (not a quorum call, but one-to-one call)
rpc OrderedRPC(Request) returns (Response) {
option (gorums.ordered) = true;
}
// Regular synchronous quorum call
rpc QuorumCall(Request) returns (Response) {
option (gorums.quorumcall) = true;
}
// This is the Qc_Future
rpc AsyncQuorumCall(Request) returns (Response) {
option (gorums.quorumcall) = true;
option (gorums.async) = true;
}
// Ordered quorum call (new)
rpc OrderedQuorumCall(Request) returns (Response) {
option (gorums.quorumcall) = true;
option (gorums.ordered) = true;
}
// This is the new Qc_Future with ordering (not yet merged)
rpc OrderedAsyncQuorumCall(Request) returns (Response) {
option (gorums.quorumcall) = true;
option (gorums.async) = true;
option (gorums.ordered) = true;
}
rpc Correctable(Request) returns (Response) {
option (gorums.correctable) = true;
}
rpc CorrectableStream(Request) returns (stream Response) {
option (gorums.correctable) = true;
}
from gorums.
Closing since this is now implemented in the reorg-generator
branch.
from gorums.
Related Issues (20)
- Decouple Node from channel to avoid two-way reference HOT 2
- Improve release automation with goreleaser
- Replace deprecated grpc.WithInsecure()
- QSpec objects versus passing quorum functions as arguments HOT 4
- Provide timeout and retry options to the NewConfiguration method
- Configurable network latencies in the configuration HOT 2
- Update user-guide.md to link to method-options.md
- feat: generic datatype for node ID HOT 1
- bug: RawNode.RPCCall returns nil instead of error
- ci: Update GitHub Actions versions to fix failing CI workflows
- deps: upgrade golang and dependency versions
- doc: gorums.NewServer claims to be for internal use
- thinking: Consider whether or not to use the WithBlock dial option HOT 1
- fix: rework the context object in gRPC calls HOT 1
- feat: Generate ServiceNameClient interface akin to gRPC's plugin
- chore: rename channel.sendMsgs
- Add example projects mainly as documentation of Gorums features
- bug: race condition when accessing configuration from separate goroutines HOT 2
- chore: update errors to follow better style and use the %w verb HOT 1
- bug: incorrect unblock behavior when using `WithNoSendWaiting` call option HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gorums.