Make Manager and Configuration an interface to ease testing about gorums HOT 3 OPEN

Here is a proposed interface for Configuration.

// Configuration represents a static set of nodes on which quorum remote
// procedure calls may be invoked.
type Configuration interface {
	Nodes() []*Node
	Size() int
	NewQuorumSpec() QuorumSpec
}

The NewConfiguration method should return the generated struct (not the interface), since then the interface does not need to contain the RPCs generated from the proto file.

The main issue is how can we access the QuorumSpec; we need generics.

from gorums.

Finally started to look into this. Sounds reasonable to me. I think it would be very useful if we can make the Manager and Configuration interfaces be part of the public API of Gorums, so that these interfaces need not be generated. This can also allow us to create helper functions, e.g. test helpers, for setting up Gorums.

from gorums.

When reviewing a PR a while back I noticed that we don't actually use the Nodes() method, nor the NodeIDs() method from within Gorums itself. The question is whether or not one or both of these methods will be useful as part of this interface.

from gorums.