Healing strategy is too agressive about adr-gateway HOT 3 CLOSED

A new connectivity module has been implemented.

The old module had Neurons and CompoundNeurons (a.k.a. Pathways). These classes contained their own graphing (extend, expand) logic as well as evaluation logic (GetWithHealing).

In the new module, we now talk about Dependencies (instead of Neurons), and a CommsDependencyEvaluator, which separates the concern of dependency specification from the implementation details of the evaluation of these dependencies.

The new design is summarised as follows:

1. Instead of establishing a graph of dependencies at runtime, a dependency graph is modelled declaratively in Dependencies.yaml. Code-gen transforms this into a collection of Dependency Objects. E.g.
2. The notion of Pathway length is replaced with a Dependency Chain. (E.g. DataHolderBrands depends on [DataRecipientJwks,RegisterOidc,DataRecipientStatus,RegisterAccessCredentials,] This chain is short (no Passthru Neurons), and explicit in each Dependency.
3. The healing process works by evaluating the dependency graph with the full chain of dependencies having caches enabled. This is passed to an optional validator. If the validation fails, then there are up to 3 retries of this process (configurable by MAXIMUM_HEALING_ITERATIONS). On each retry, a further 3rd of the caches are demoted (deactivated for the next evaluation run).
4. A cached dependency can have a minAge and a maxAge, and a validator. If the value from the cache is not valid, the dependency is always re-evaluated. If it is older than maxAge, it is always re-evaluated. If the value in the cache is younger than minAge, the cache is always honoured and the dependency is not re-evaluated (even during healing).

As a result of this design, the maximum response time in the worst case that an error is unrecoverable remains short. Additionally we are able to prevent abuse of other ecosystem participants by the use of minAge and the known configurable retry limit.

from adr-gateway.

This will be released as a version 1.1 in the coming days.

from adr-gateway.

Solved with 5771aa9

from adr-gateway.