Giter Club home page Giter Club logo

Comments (4)

wycats avatar wycats commented on May 28, 2024

Why doesn't cargo-modules expand macros before building the graph?

from cargo-modules.

regexident avatar regexident commented on May 28, 2024

@wycats historically speaking because I back then tried to avoid adding too many moving parts, given that I already had to frequently fix breakage due to unstable syntex_syntax dependency.

There is no reason why it should not expand macros now. I'm wondering though if it wouldn't then make more sense to go all in, turn cargo-modules into a rustc_driver and walk the HIR instead, which should get us the name resolution for free. Something that @muhuk has been doing tremendous manual work recently, in an effort to add support for Edition 2018.

from cargo-modules.

muhuk avatar muhuk commented on May 28, 2024

...and he still needs to do some more work, to finalize it.

Soon I'll get to it.

from cargo-modules.

regexident avatar regexident commented on May 28, 2024

This should now be fixed with #66 having been merged. 🎉 😃
(The release still needs a it more work. If you're feeling lucky you can install from source and give it a try, though.)

from cargo-modules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.