Giter Club home page Giter Club logo

Comments (3)

dthyresson avatar dthyresson commented on August 27, 2024

Hi @Firokat and thanks for using directives and tests — and reporting this. I’ll have to go back as see why we had the specific async mock and when it was removed.

Your approach to resolve or reject seems sensible and depending on what I find that might be the docs update we need.

Very helpful to have the reproduction here. Thanks!

from redwood.

dthyresson avatar dthyresson commented on August 27, 2024

FYI some history is here #5822
I think the implementation had the separate Async mocks and then as part of the review we elected to keep the same mock but just let it handle both. But while that was updated and the template also — the original doc update never got corrected.

So your method of testing is correct — I’ll make a docs change to clarify how to test async directives properly.

Thanks!

from redwood.

Firokat avatar Firokat commented on August 27, 2024

Hi, thanks for looking into this as quickly as you did !
Glad to hear that it will lead to a change to the doc.

from redwood.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.