Comments (5)
Works a bit like useErrorStyles
hook for custom classes. So much so that the component above can be simplify to just:
import { ComponentProps } from 'react'
import {
Controller as RedwoodController,
useErrorStyles,
} from '@redwoodjs/forms'
const ServerAwareController = (
props: ComponentProps<typeof RedwoodController>
) => {
useErrorStyles({ name: props.name })
return <RedwoodController {...props} />
}
export default ServerAwareController
My personal opinion is this would make for a very easy and useful wrapper to rhf controller
from redwood.
I fixed it by making a custom wrapper for the react-hook-form controller like:
import { ComponentProps, useContext, useEffect } from 'react'
import {
Controller as ReactHookFormController,
ServerErrorsContext,
useFormContext,
} from '@redwoodjs/forms'
const ServerAwareController = (
props: ComponentProps<typeof ReactHookFormController>
) => {
const { name } = props
const { setError } = useFormContext()
const serverError = useContext(ServerErrorsContext)[name]
useEffect(() => {
if (serverError) {
setError(name, { type: 'server', message: serverError })
}
}, [serverError, name, setError])
return <RedwoodController {...props} />
}
export default ServerAwareController
I think this would be nice to have it build it into the framework to able to use with existing FieldError
and Label
components
from redwood.
Thank you @irg1008 again for raising an interesting issue, and for the solution here.
I am not a forms expert, but the solution you've suggested here seems quite reasonable. Can you think of a case where you wouldn't want the error styles coming through in a controller?
i.e. Does it make sense to change the export of Controller
to be ServerAwareController
from redwood.
Hi @irg1008
i.e. Does it make sense to change the export of Controller to be ServerAwareController
am following up here to see what you think of @dac09 proposal or if this scenario could just use some documentation that shows your solution?
from redwood.
Yeah I have been pretty busy this week, I will get that moving this weekend np
from redwood.
Related Issues (20)
- [Bug?]: yarn rw setup server-file fails with js but works with ts HOT 5
- Multiple RW apps all use the same debug port HOT 2
- Syntax check `package.json` for dual ESM+CJS support in `@redwoodjs/auth`
- [Bug?]: cannot set bodyLimit using server.ts HOT 2
- [Bug?]: Clarify impact on database file location with prisma multi file schema HOT 2
- [Bug]: Flaky dbAuth test in framework tests
- [RWUploads] Spike prisma extensions and if its possible to detect a specific model
- [RWUploads] Spike Prisma single table inheritance
- Background Jobs: Re-work to procedural design
- [Bug?]: Generate page command not working HOT 4
- [Bug?]: Fastify server throws an error when using custom server.ts and enriched graphql yoga server HOT 6
- [Bug]: Server doesn't handle periods in path parameters HOT 1
- [Bug?]: Storybook won't work with Mantine HOT 2
- [Bug?]: Realtime context typescript error, no redis keys created HOT 4
- Add Documentation for Alias paths within Jest HOT 1
- Add Documentation for Working with Playwright
- Add Documentation for Working with ShadCN
- Fix code samples in caching doc
- More background job tests
- Upgrade Spoke to latest v8.RC, add background jobs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redwood.