[RFC]: FieldError not being populated with server errors when inside Controller when using custom UI components about redwood HOT 5 OPEN

Works a bit like useErrorStyles hook for custom classes. So much so that the component above can be simplify to just:

import { ComponentProps } from 'react'

import {
  Controller as RedwoodController,
  useErrorStyles,
} from '@redwoodjs/forms'

const ServerAwareController = (
  props: ComponentProps<typeof RedwoodController>
) => {
  useErrorStyles({ name: props.name })
  return <RedwoodController {...props} />
}

export default ServerAwareController

My personal opinion is this would make for a very easy and useful wrapper to rhf controller

from redwood.

I fixed it by making a custom wrapper for the react-hook-form controller like:

import { ComponentProps, useContext, useEffect } from 'react'

import {
  Controller as ReactHookFormController,
  ServerErrorsContext,
  useFormContext,
} from '@redwoodjs/forms'

const ServerAwareController = (
  props: ComponentProps<typeof ReactHookFormController>
) => {
  const { name } = props

  const { setError } = useFormContext()
  const serverError = useContext(ServerErrorsContext)[name]

  useEffect(() => {
    if (serverError) {
      setError(name, { type: 'server', message: serverError })
    }
  }, [serverError, name, setError])

  return <RedwoodController {...props} />
}

export default ServerAwareController

I think this would be nice to have it build it into the framework to able to use with existing FieldError and Label components

from redwood.

Thank you @irg1008 again for raising an interesting issue, and for the solution here.

I am not a forms expert, but the solution you've suggested here seems quite reasonable. Can you think of a case where you wouldn't want the error styles coming through in a controller?

i.e. Does it make sense to change the export of Controller to be ServerAwareController

from redwood.

Hi @irg1008

i.e. Does it make sense to change the export of Controller to be ServerAwareController

am following up here to see what you think of @dac09 proposal or if this scenario could just use some documentation that shows your solution?

from redwood.

Yeah I have been pretty busy this week, I will get that moving this weekend np

from redwood.