Comments (9)
Thanks @Tobbe! Unfortunately 5.4.2 is also broken. The solution is to stay on 5.3.x for now.
from redwood.
It's working 👍🏻. I was using
"resolutions": {
"typescript": "5.3.2"
}
to keep up with latest Redwood without breaking my dev environment.
Thanks @Josh-Walker-GM and @Tobbe !
from redwood.
Update!!
I've been able to track this issue down to exactly this:
chore(deps): update dependency typescript to v5.4.3
VS Code uses its own bundled typescript. If you see here, VS Code 1.88 just got rolled out with typescript v5.4 - version 1.87 and previous versions were using typescript <= 5.3. That's why I had it breaking with Neovim but not VS Code.
This is not something that affects Redwood exclusively. The simplest way to reproduce this bug is to create a Vite app using React + Typescript, install some package (Lucide or Jotai like I used as example, or any other), and just bring autocomplete to see if any imports show up. If you get your hands on VS Code >= 1.88, the same issue stated above should happen to you.
Worth remembering that this is only affecting .js
and .jsx
files.
from redwood.
Thanks for the update @higajooj! That's some great detective work right there 🙂 🕵️
As a workaround for any VSCode users you can downgrade your RW project's TS version to 5.4.2 and then tell VSCode to use the workspace version of TS instead of its built-in version. Just click the TS version number in the status bar, and choose 5.4.2 in the popup you get at the top of the screen
(I'm still on an older version of VSCode, and have 5.4.3 as my workspace version. Your numbers will look different)
from redwood.
@higajooj BTW, is this only for RW projects, or do you see the same issue in other projects as well?
from redwood.
@Tobbe, both Redwood and plain Vite apps are affected (npm create vite
). I'm not sure about other frameworks.
from redwood.
Fixed on TypeScript 5.4.5
microsoft/vscode#209849 (comment)
microsoft/TypeScript#57740
microsoft/TypeScript#58115
microsoft/TypeScript#58113
from redwood.
Hey @higajooj, I just merged in the dependency upgrade, confirmed it fixed the problem for me locally then released it in v7.4.1. Can you confirm that v7.4.1 works as expected for you?
from redwood.
Fixed in #10452
from redwood.
Related Issues (20)
- [Auth] Common AuthProvider & use* changes for middleware auth HOT 1
- [OG] Finish OG Image generation with updated middleware implementation HOT 1
- [Auth] Implement dbAuth middleware
- [Auth] createMiddlewareAuth (web side) for dbAuth
- [Auth] Implement POST handlers for login, signup, etc. on dbAuth
- [Bug?]: dbAuth `userAttributes` comment error HOT 7
- [Bug?]: Uploading files through custom functions doesn't work HOT 1
- [Bug?]: Updating from 7.3.0 to 7.4.1 will fail, if there is no npx available HOT 4
- [Bug?]: console prints wrong GraphQL endpoint when apiGraphQLUrl is set in dev enviornment HOT 4
- [Bug?]: client-build-manifest.json needs an import assertion of type "json" when using RSC HOT 6
- [Bug?]: Cannot wrap components in RedwoodApolloProvider in jest tests HOT 7
- [Bug?]: ERROR Function "" was not found. HOT 8
- [Bug?]: HydrateRoot and TypeError: Cannot read properties of undefined ... at Object.prerenderLoader on whichever page first loads HOT 5
- [Bug?]: Seeing 500s due to ERR_STREAM_PREMATURE_CLOSE after upgrade to 7.x HOT 4
- [Bug?]: fastify compress plugin not working as per docs HOT 2
- [Bug?]: nftPack: undefined is not a function HOT 9
- [Bug?]: Authentication Error After Upgrading from Version 6.6.4 to 7.4.3 HOT 3
- [Docs]: useCache!!! HOT 1
- [Bug?]: Setting --verbose when deploying to baremetal "fails" during cleanup step. SshExecutor.js does not check that "args" is defined. HOT 6
- [Bug?]: yarn rw setup auth supabase not working HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redwood.