Duplication Result parameter in generics about reselect HOT 9 CLOSED

I'm kinda confused. Can you give an example of when you feel you need to explicitly specify the type?

Reselect's current types are designed to infer as much as possible, and you generally shouldn't be explicitly providing generic arguments to createSelector.

from reselect.

At the moment, we have recently migrated a large project from flow to typescript and the typing of the code leaves much to be desired. Automatic type inference often outputs any. By explicitly specifying the types for the combiner, we also fix the composition of selectors inside createSelector

from reselect.

You're supposed to use Reselect the other way around :)

Type the input function arguments correctly, and everything else should get inferred right.

In this case, go back to the definitions of selectCheckoutCartGroups, selectCheckoutCarts , etc, and make sure that their input functions have the right types, like:

const selectCheckoutCartGroups = createSelector(
  (state: RootState) => state.some.cart,
  (state: RootState, someOtherArg: number) => someOtherArg,
  (cart, someOtherArg) => // whatever here
)

// selectCheckoutCartGroups is now typed as;
// (state: RootState, someOtherArg: number) => whateverYourReturnValueIs

Do that for each of those selectors, and the types will propagate through correctly.

from reselect.

While we're at it, what is this stateCreator function?

from reselect.

While we're at it, what is this stateCreator function?

Probably a bad example
This is a legacy code, there is nothing good there, unfortunately :)

from reselect.

You're supposed to use Reselect the other way around :)

Type the input function arguments correctly, and everything else should get inferred right.

In this case, go back to the definitions of selectCheckoutCartGroups, selectCheckoutCarts , etc, and make sure that their input functions have the right types, like:

const selectCheckoutCartGroups = createSelector(
  (state: RootState) => state.some.cart,
  (state: RootState, someOtherArg: number) => someOtherArg,
  (cart, someOtherArg) => // whatever here
)

// selectCheckoutCartGroups is now typed as;
// (state: RootState, someOtherArg: number) => whateverYourReturnValueIs

Do that for each of those selectors, and the types will propagate through correctly.

Yes, this is the ideal option that we are striving for. Unfortunately, now at the moment there is a need for part of the team to type explicitly. Even the described types do not always give the expected result. To increase readability, we would like to remove an extra parameter that is duplicated in the type. Of the options was to redefine them locally or come here with a suggestion :)

from reselect.

@AlbertFib : why do you need to "type explicitly"?

from reselect.

@AlbertFib : why do you need to "type explicitly"?

In some places we consciously want to type explicitly and control the return type of the created selector, and not rely on automatic output, so that if the selector changes, we get a type error in this place.

from reselect.

Honestly, you're bringing the pain upon yourself :)

We designed Reselect's types to infer as much as possible, so that you don't have to write all the types out explicitly.

Given that, I don't think we're going to make a change here.

from reselect.