I have a bit of a strange situation going on, perhaps as a result of incorrect usage.<

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

race function not behaving as expected. about redux-saga HOT 6 CLOSED

redux-saga commented on May 28, 2024

race function not behaving as expected.

from redux-saga.

Comments (6)

mattmarcello commented on May 28, 2024

I can achieve the desired functionality by wrapping the calls to take in generator functions, as follows:

function* waitForDashboardChange() {                                                                                                                                                                                                                                                  
  return yield take(DASHBOARD_LOAD_REQUEST);                                                                                                                                                                                                                                         
}                                                                                                                                                                                                                                                                                    

function* waitForExplicitLogout() {                                                                                                                                                                                                                                                  
  return yield take(LOGOUT);                                                                                                                                                                                                                                                         
}

Then, the race becomes:

    const { explicitLogout, dashboardChange } = yield race({                                                                                                                                                                                                                          
      dashboardChange: call(waitForDashboardChange),                                                                                                                                                                                                                                   
      explicitLogout: call(waitForExplicitLogout),                                                                                                                                                                                                                                   
    })

Is this the intended API?

from redux-saga.

yelouafi commented on May 28, 2024

concurrent takes within race are not allowed until now; but should be supported as soon as #26 get merged.

For now you can take multiple actions like this

   const action = yield take([DASHBOARD_LOAD_REQUEST, LOGOUT])
   if(action.type === DASHBOARD_LOAD_REQUEST)
     ....
   else
     ...

from redux-saga.

mattmarcello commented on May 28, 2024

@yelouafi
Would you say there is anything fundamentally wrong with wrapping the takes in functions as demonstrated above? If not, would it make sense to document?

from redux-saga.

yelouafi commented on May 28, 2024

Would you say there is anything fundamentally wrong with wrapping the takes in functions as demonstrated above?

No. It just adds a level of indirection.

from redux-saga.

yelouafi commented on May 28, 2024

Which in some cases could be useful of course

from redux-saga.

yelouafi commented on May 28, 2024

FYI, the new version 0.4.0 supports concurrent or parallel takes

the code below is now valid

const { explicitLogout, dashboardChange } = yield race({                                                                                                                                                                                                                                          
  dashboardChange: take(DASHBOARD_LOAD_REQUEST),                                                                                                                                                                                                                            
  explicitLogout: take(LOGOUT),                                                                                                                                                                                                                                            
})