Giter Club home page Giter Club logo

Comments (6)

Jeffail avatar Jeffail commented on July 20, 2024

Hey @cludden, if the input/output targets are generally useful then I'd be interested in adding them to the project, otherwise you can fork and I'll still be happy to guide you. The process is pretty simple, check out the examples in https://github.com/Jeffail/benthos/tree/master/lib/input/reader.

I'm trying to avoid plugins for now as I like the simplicity of having "one true Benthos", but obviously if the list of components gets outrageously large I'll revisit, not sure how I'd manage builds in that case but the technical side shouldn't be an issue.

from connect.

Jeffail avatar Jeffail commented on July 20, 2024

Marking this as documentation as it would be nice for me to outline the current process for contributing components.

from connect.

cludden avatar cludden commented on July 20, 2024

Hey @Jeffail thanks for the quick response, what you've stated was the same as my initial thoughts, and I have no problem submitting PR's for my use cases. However, the particular input I would like to implement (mysql binlog consumer) requires an additional storage layer for persisting consumer state (files and offsets), which can also be pluggable. As opposed to creating a truly generic mysql input (as in, bring-your-own backend), it seemed it would be simpler if I could just define my own structure that satisfied the benthos input interface and be on my way, plus i wasn't sure how useful it would be as part of the benthos core. Would you prefer this as a core input (i'll gladly submit a PR), or would a fork be the better solution?

from connect.

Jeffail avatar Jeffail commented on July 20, 2024

Let's do a fork for now. There's similar patterns I'm currently looking at where we want to have a consumer and then a separate storage layer so maybe in the future there will be a general pattern we could fit something like this into.

from connect.

cludden avatar cludden commented on July 20, 2024

sounds good!

from connect.

cludden avatar cludden commented on July 20, 2024

i'll leave it open for the documentation tag you added, thanks again!

from connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.