AMQP TLS support about connect HOT 8 CLOSED

Hey @EdeMeijer, done. 22c185d, I haven't got a TLS enabled server to test against so would be good if you could try it out and get back to me.

from connect.

Wow, that's fast. I'll let you know when I get around to testing it, thanks.

from connect.

I got a TLS secured RabbitMQ instance up and can access the management interface over HTTPS, so the certs are configured correctly on the server side. I tried settings up an amqp input with benthos but I'm getting a tls handshake failure. I'll send you an email with the details where you can find the server for testing and what I tried so far, just don't want to share that here.

from connect.

Cool, sounds good, thanks @EdeMeijer

from connect.

Okay, that was my bad. I had peer verification enabled but not configured. Benthos now happily consumes my test queue.

That raises the question though, is TLS peer verification supported by Benthos? That might be another good thing to test.

from connect.

Another thing. When using amqp as input, Benthos creates a benthos-exchange exchange and binds it to the configured queue with a benthos-key as routing key. I don't see why this is done, since consuming a queue only requires a queue, and not a bound exchange.

Of course, I could see the benefit in optionally binding your Benthos queue to an existing exchange, but that would require a slightly different approach. Maybe this should be a new issue though.

from connect.

I believe you should be able to do peer verification by exporting your certs and pointing Benthos to them with the tls.cas_file field.

The exchange declaration and binding on the input should be a no-op if they already exist, but you're right that it's redundant. I can't exactly remember why I set it up this way originally but you're right to point it out, it's annoying to have to redundantly specify your exchange fields and binding when they should already exist. I'll take a look.

from connect.

Moving declaration discussion over to #45, would be good to get your thoughts. Closing this issue.

from connect.