Giter Club home page Giter Club logo

Comments (2)

slorello89 avatar slorello89 commented on August 24, 2024

@uglide - the appveyor tests for StackExchange.Redis are testing on windows servers against a version of Redis 3.1 built to run on Windows servers, hence they are not a valid gauge for whether it's running the thing or not, in the days of old GitHub actions did not support Windows VMs hence the bifurcation in builds. We did extensively test TLS capabilities as part of StackExchange/StackExchange.Redis#2219. the CertificateValidation workflow is somewhat obsolete with the introduction of SslClientAuthenticationOptions in .NET Core 3.1 (See RU102N Redis for .NET Developers Section 1.4.2), a delegate for which was which was added at the time to StackExchange.Redis.

Is there a definitive need for this to be tested against Redis Cloud or would it be sufficient to test it against. a TLS Enabled version of Redis as it's done in StackExchange.Redis. Do we want to add a hard dependency for CI on an external service? We were trying to avoid exactly this two weeks ago to do all the testing for .NET Framework.

from nredisstack.

uglide avatar uglide commented on August 24, 2024

@slorello89 Thanks for pointing it out. For me, it sounds like we should provide two examples for .NET 4 with options.CertificateValidation and .NET 5+ with SslClientAuthenticationOptions instead of insecure return true; like here https://github.com/StackExchange/StackExchange.Redis/blob/9698aaa8c5e372a73e0dec0adeeb9c85c09dd7f9/tests/StackExchange.Redis.Tests/SSLTests.cs#L207

We should test end-to-end with Redis cloud to guarantee the best developer experience. I don't know what to add here or how to achieve it without dependency on real Redis Cloud with TLS.

from nredisstack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.