Comments (2)
@uglide - the appveyor tests for StackExchange.Redis are testing on windows servers against a version of Redis 3.1 built to run on Windows servers, hence they are not a valid gauge for whether it's running the thing or not, in the days of old GitHub actions did not support Windows VMs hence the bifurcation in builds. We did extensively test TLS capabilities as part of StackExchange/StackExchange.Redis#2219. the CertificateValidation
workflow is somewhat obsolete with the introduction of SslClientAuthenticationOptions
in .NET Core 3.1 (See RU102N Redis for .NET Developers Section 1.4.2), a delegate for which was which was added at the time to StackExchange.Redis.
Is there a definitive need for this to be tested against Redis Cloud or would it be sufficient to test it against. a TLS Enabled version of Redis as it's done in StackExchange.Redis. Do we want to add a hard dependency for CI on an external service? We were trying to avoid exactly this two weeks ago to do all the testing for .NET Framework.
from nredisstack.
@slorello89 Thanks for pointing it out. For me, it sounds like we should provide two examples for .NET 4 with options.CertificateValidation
and .NET 5+ with SslClientAuthenticationOptions
instead of insecure return true;
like here https://github.com/StackExchange/StackExchange.Redis/blob/9698aaa8c5e372a73e0dec0adeeb9c85c09dd7f9/tests/StackExchange.Redis.Tests/SSLTests.cs#L207
We should test end-to-end with Redis cloud to guarantee the best developer experience. I don't know what to add here or how to achieve it without dependency on real Redis Cloud with TLS.
from nredisstack.
Related Issues (20)
- Add support for BLMPOP
- Add support for BLPOP
- Add support for BRPOP
- Add support for BRPOPLPUSH
- Add support for XREADGROUP
- Trying to add nested JSON fields returns success, but doesnt update JSON
- TestJsonTransaction seems to fail arbitrarily HOT 2
- Index.Attribute throws error for sortable fields HOT 7
- FT.Aggregate with APPLY - text fields data is returing in lowercase if we do the multi column sort HOT 7
- Add support for IBatch.JSON() HOT 1
- TimeSeries - Insertion-filter for close samples
- test support for dialect 5 in RediSearch exact matching
- fix result data change for FT.PROFILE
- support for serch with polygons HOT 1
- FT.PROFILE command response layout change
- Support for indexing and querying missing and empty values
- Support for bfloat16 and float16 types in vector fields indexing
- NRedisStack not writing timeseries values to Valkey HOT 1
- TimeSeries Create function always creates the TS as "uncompressed" when specifying true or false to the function argument HOT 1
- Doc tests are failing randomly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nredisstack.