Giter Club home page Giter Club logo

Comments (10)

shacharPash avatar shacharPash commented on August 24, 2024 1

@haysch We can use what you already have as a base and make changes to fit exactly our needs.
What are you saying?

from nredisstack.

haysch avatar haysch commented on August 24, 2024 1

Will tidy it a bit up, and then open a PR.

By the way, thanks for an awesome and active library - your work is highly appreciated 👍

from nredisstack.

shacharPash avatar shacharPash commented on August 24, 2024

@haysch Thanks for the feedback!
Dev Containers sounds like a good idea
Do you have experience with it?

from nredisstack.

haysch avatar haysch commented on August 24, 2024

I have been using it for a while on a smaller scale, so nothing fancy.

I already have a devcontainer setup for NRedisStack that I have been using for a while as it was somewhat quick and painless to support multiple Redis, and .NET, versions 💡

from nredisstack.

haysch avatar haysch commented on August 24, 2024

How do we want to support multiple Redis versions?

The pipeline tests three different versions, but the test suite uses a single REDIS env variable or localhost:6379, if env variable is not set.

How do you usually do it today?

In my environment I have spinner up the three versions used by the pipeline, and then specify different test tasks that points to the respective Redis instance.

from nredisstack.

shacharPash avatar shacharPash commented on August 24, 2024

Locally I test against redis-stack:edge. And the CI also checks the other versions for me.
Sounds like what you offer is better.

from nredisstack.

shacharPash avatar shacharPash commented on August 24, 2024

@haysch How's it going? Do you want to send what you have in the meantime and we will continue together?

from nredisstack.

haysch avatar haysch commented on August 24, 2024

Will have some time in the evening.
Life has been going on 🙂

from nredisstack.

haysch avatar haysch commented on August 24, 2024

@shacharPash Added an initial commit, but it seems like some tests are failing for v6.2.6 and v7.0.6 - any idea why?

Please let me know what you think, or make any changes as you see fit!

from nredisstack.

shacharPash avatar shacharPash commented on August 24, 2024

completed in #169

from nredisstack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.