Make NavDropdown check for expandable rely on dropdown-toggle class instead of span.caret about widgetastic.patternfly HOT 5 CLOSED

Nevermind, my selector was actually selecting the a instead of the li and that is why it was failing.

from widgetastic.patternfly.

I am leaving this open in case you decide using the dropdown-toggle class would be better than caret

from widgetastic.patternfly.

Also maybe the docstring of NavDropdown (https://github.com/RedHatQE/widgetastic.patternfly/blob/master/src/widgetastic_patternfly/__init__.py#L311) could be expanded to:

The dropdowns used eg. in navigation. Usually an element with a class of ``dropdown`` located in the top navbar.

from widgetastic.patternfly.

Just saw this - but I ended up hitting the same issue @elyezer and have addressed it in #98.

Thanks!

from widgetastic.patternfly.

I see now #98 was merged yesterday, manually closing this. @elyezer don't hesitate to open another issue, or PR, if the change made in 98 is not workable for your use.

from widgetastic.patternfly.