[RFE] Lifecycle controller removal about badfish HOT 2 CLOSED

I am not sure if the create_bios_config_job function should be removed/is not needed. 😅
Investigated it a bit and here is what I got 🕵️‍♂️:

• I picked the change_boot functionality for testing it. (Was monitoring the behavior through virtual console.)

• Here is how it works with the create_bios_config_job still in place:

  • First I set the boot to director type as a starting point.
  • Then I run the command to change it to foreman, which it did.
  • After it was done, I ran the command to change boot to foreman again, and it didn't go through because it said that it's already in that config. This was expected and worked like it should.

• Now I went and removed the call to create_bios_config_job from the change_boot function and tried to do this again:

  • Changed the boot to director, went through.
  • Then changed the boot to foreman, went through, all good.
  • Ran it again to set the boot to foreman, but got no message saying it is in that config now, and the command went trough, restarted the server and just executed all of itself again.

From seeing this behavior I don't think the call to create_bios_config_job is there without it's purpose as the command clearly works differently when that function is used compared to when not. Also while restarting certain steps using the Lifecycle Controller were executed only when using that function/creating the bios job (Monitored on virtual console). The settings may not actually apply without it, or they might not be surviving a reboot.

from badfish.

Based on: dell-racadm-bios-nic-techsheet.pdf
Seems like what it would be optional for creating the job is actually the reboot job.
Closing issue as won't resolve.

from badfish.