Semantic highlighting for lambdas about vscode-java HOT 5 CLOSED

If you use the command "Developer: Inspect Editor Tokens and Scopes" to inspect the token type, you can see that we already assign different semantic token types for them. For the field, its semantic token type is property, and for the variable, its semantic token type is variable. It's the color theme that's responsible for rendering the color highlighting.

A workaround for you is to customize the semantic highlighting color in the settings.json by yourself.

"editor.semanticTokenColorCustomizations": {
        "[Default Light Modern]": {
            "rules": {
                "property": "#9089f4"
            }
        }
    }

from vscode-java.

Makes sense. I would actually go further, and say the highlighting doesn't even distinguish between class fields and other variables. For example, Eclipse clearly does this :

VS Code Java

Eclipse JDT

Note : Obviously, we can't fix this in the grammar, but our semantic highlighting (language server) is definitely able to deal with this. @testforstephen any reason not to do this ?

from vscode-java.

Thanks for looking into this!

In fact, even the lambda parameter has a semantic token type of parameter, so this can all be fixed with something like :

"editor.semanticTokenColorCustomizations": {
        "[Default Light Modern]": {
            "rules": {
                "property": "#9089f4",
                "parameter": "#9089f4"
            }
        }
    }

@Phoenix-Starlight , let us know if this works for you. It would have to be configured per-theme. See https://code.visualstudio.com/docs/getstarted/themes#_editor-semantic-highlighting .

from vscode-java.

Closing this for now as it's mainly an issue with the themes provided, and there is a way to configure.

from vscode-java.

Hi, I'm back again. Another case is

public bar(Foo foo) {
  pack(() -> foo);
}

This captures the parameter foo, but there is no way to distinguish this.

from vscode-java.