Giter Club home page Giter Club logo

Comments (3)

qtxie avatar qtxie commented on May 27, 2024

The length of the bitset should be taken into account.

>> c1
==  make bitset! #{FFFF}      ;-- "11111111.11111111"
>> c2
== make bitset! [not #{7E}]   ;-- "10000001"
>> length? c1
== 16
>> length? c2
== 8
>> c3: c1 and c2
== make bitset! [not #{7E}]   ;-- "10000001"
>> length? c3
== 8

c1 and c2 is correct.

from red.

hiiamboris avatar hiiamboris commented on May 27, 2024

No it's not correct. Length is just an internal implementation detail. Implementation should not drive the design. Design should drive the implementation.

from red.

hiiamboris avatar hiiamboris commented on May 27, 2024

General rules for bitsets should be:

  1. Result length should equal the longest operand's length, and may be zero:
    >> (charset []) or (charset [not]) 
    == make bitset! [not #{FF}]     ;) length was extended leading to wrong result! expected [not #{}]
    
  2. Negation flag may be freely set by binary operations depending on whether the trail should be set or not, e.g.:
    >> (charset [not]) and (charset [])
    == make bitset! [not #{}]       ;) expected empty set, got full set!
    >> (charset [not]) and (charset [not]) 
    == make bitset! #{}             ;) expected full set, got empty set!
    

Current builds of Red, R3 and Ren-C I have all fail the bitset math. @Oldes @hostilefork FYI.

from red.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.