Misbehavior by ExplicitReturnNull rule about rector HOT 3 CLOSED

I see, reopen then.

from rector.

That is expected, if no return in root last stmt, then add return null, except on finally, you specify return as well, see https://getrector.com/demo/a9aa21cf-63ad-4593-9d43-5e9328ebcc38

You can skip the rule if that not what you want https://getrector.com/documentation/ignoring-rules-or-paths

from rector.

@samsonasik
This is incorrect behaviour, see example:

final class ExampleTest extends UnitTestCase
{
    public function testExample(): void
    {
        $result = $this->example();

        $this->assertSame(1, $result); // Failed asserting that null is identical to 1.
    }

    private function example()
    {
        try {
            return 1;
        } finally {
            return null;
        }
    }
}

Rector changes the behavior of the code, making it incorrect.

If we do as the rector suggests initially, we get errors from static analyzers. They say that this line of code will never be executed. And they are right:

try {
    return 1;
} finally {
    // do something
}

// unreachable statement
return null;

Yeah, I turned off the rule. But its incorrect behavior will result in nobody using it.

from rector.