Comments (3)
I think that's trade off based on caller, check instanceof inside union type each other sub type is memory intensive, as it will make double loop per-type, and code transformation is valid. I think you can verify code after transformation by hand ;)
from rector.
Yeah, I thought about that, too. For me it was a tricky one: is it a bug, or a feature? Guess it's the latter 😂
from rector.
That's a chore I guess
from rector.
Related Issues (20)
- example of rector.php config file with all rules and sets included but commented HOT 7
- [DX] Accept y[es] and n[o] for initial config generation HOT 1
- RectorConfigBuilder feedback HOT 5
- RemoveAlwaysTrueIfConditionRector remove functional condition HOT 1
- Error when using PHPStan bleeding edge HOT 5
- Unneeded brackets in variable declaration HOT 1
- Remove "/vendor" from Rector paths and run again. HOT 6
- Incorrect behavior of LocallyCalledStaticMethodToNonStaticRector on call via static:: of other method from static method
- Incorrect behavior of StringExtensionToConfigBuilderRector HOT 2
- AddOverrideAttributeToOverriddenMethodsRector adds Override attribute to methods implementing interface HOT 6
- Incorrect behavior of CompleteDynamicPropertiesRector
- Incorrect behavior of RemoveParentCallWithoutParentRector HOT 5
- System error: "Node "PhpParser\Node\Expr\FuncCall" with is missing scope required for scope refresh HOT 1
- Bad behavior of DirNameFileConstantToDirConstantRector HOT 4
- Incorrect behavior of ReturnTypeFromStrictNewArrayRector HOT 1
- SetList::CODE_QUALITY HOT 2
- Rector automatization: generate commits with every rule changes HOT 3
- Import statement removed while in use HOT 1
- AssignArrayToStringRector bad behavior HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rector.