addViewToWindow() crashes with IllegalStateException about floatingview HOT 10 CLOSED

In real project showing/hiding of FloatingView is controlled by observing androidx.lifecycle.ProcessLifecycleOwner inside Service. Sometimes user actions combined with other work in Android main thread results in lifecycle events delivered in quick succession. Specifically I suspect addViewToWindow() and immediately removeAllViewToWindow() produces abnormal state, so next call to addViewToWindow() (even after some delay) crashes.

This happens rarely (~20 crashes per week among 300 users). I reproduced it after many minutes of repeated quick switching between our app and home screen. So the purpose of my demo project was not to avoid crash, but to reproduce crash reliably. ;)

from floatingview.

@gmk57 I applied the change you suggested and tested the sample project you created (in the OP).

Not the cleanest solution, but it certainly seems to have fixed the crashes! 🎉

It will have to do for now.

from floatingview.

Please check on Ver 2.4.1

from floatingview.

FloatingViewManager should be used within Service. It can not be used within Activity. For details, please read the README.
Also, FloatingView is not designed to work according to Activity's lifecycle. If you want to use PIP (Picture In Picture), please use another library.

from floatingview.

Of course, in real project we use it in Service, and exactly the same crash happens there. Test project does not bother with services for the sake of simplicity. And we show FloatingView when/if app in NOT visible, so PIP is not an option. Please reopen.

from floatingview.

I changed 'FloatingViewTest' to code that uses Service. It did not crash.
Also, when rewriting to this code, it did not crash.

        handler.post(new Runnable() {
            @Override
            public void run() {
                ImageView view = new ImageView(MainActivity.this);
                view.setImageResource(R.mipmap.ic_launcher);
                floatingViewManager.addViewToWindow(view, new FloatingViewManager.Options());
                if (!isFinishing()) {
                    handler.postDelayed(this, 3000L);
                }
            }
        });

        handler.postDelayed(new Runnable() {
            @Override
            public void run() {
                floatingViewManager.removeAllViewToWindow();
                if (!isFinishing()) {
                    handler.postDelayed(this, 3000L);
                }
            }
        }, 1000L);```

from floatingview.

Thank you for the insights, @gmk57!

Have you guys found a workaround? @YoshihideSogawa

from floatingview.

Given that v2.3.2 does not seem to have this issue, one possible solution is to replace checking for ViewCompat.isAttachedToWindow() in FloatingViewManager.removeViewImmediate() with simple try/catch. But this should be tested on device with Android 8 (where #89 is reproducible), and I don't have one at hand.

from floatingview.

@YoshihideSogawa What do you think about implementing above-mentioned workaround?

from floatingview.

Thank you very much! In test project v2.4.1 works fine, we'll try it in real life soon.

from floatingview.