Lines directly on the lower or upper bound of a Y-axis with custom domain and allowDataOverflow gets partially clipped out of view about recharts HOT 4 OPEN

@ckifer Yeah, I agree this is expected behavior since we don't want any lines past the edges of the chart when using allowDataOverflow.

I think this was mainly a "want to have" because I'm mostly using line charts with allowDataOverflow on the YAxis (due to variance of some data) and customers mention the lines "looking thinner / halved" on the edges of the chart. No worries on fixes or actions at the moment, just wanted to start the conversation around this in case others were wanting something similar.

from recharts.

Cool, thanks for the context.

It might be reasonable to say "if there is an line that will be clipped horizontally in half, expand the domain slightly but cut off everything after that"

but if you had a larger strokeWidth (say 10 or something), one might not want the graph domain expanded by 5 units to accommodate the entire item. Especially if the domain starts at something like 0. Or if you had another shape/line that expanded further down under the domain minimum

from recharts.

I guess to me this is expected? There is a clip path and that clip path is at the edge of the chart - if there is a line exactly at that edge it will clip half of the line.

We will have a conundrum if some people want things clipped and some do not.

This might be a start of a larger conversation around what allowDataOverflow actually does and how things are affected based on other settings. I don't really have any great answers or quick fixes at the moment though

from recharts.

No problem, thank you for taking a look.

It might be reasonable to say "if there is an line that will be clipped horizontally in half, expand the domain slightly but cut off everything after that"

Exactly this. Lines on the edges should be fully visible (no longer clipped in half) from the slightly expanded domain and lines that actually cross the edges due to data points going out the top or bottom of the graph should still be clipped/hidden because they will potentially be "behind" the lines strokeWidth directly on the edges and then cut off everything after that.

Ya, that's a good point about larger strokeWidths. Definitely agree there should be a limit or rules where this domain expanding doesn't always happen if the strokeWidth is greater than some value.

from recharts.