Missing error handling on allocation failure about recastnavigation HOT 5 CLOSED

I would offer to send a pull request for the core code, but it's not really possible to fix the problem for users that are not notified about this change, because they will need to check the return value of a function that previously did not return a value.

Affected APIs would be:

rcAddSpan
rcAddSpans
rcRasterizeTriangle
rcRasterizeTriangles (3 overloads)

They all have a "ctx" parameter for error reporting though, so it would only affect the return value change from void to bool.

from recastnavigation.

Hi,

I think it is ok to add return bool value and add an error message on those
functions to indicate that they have failed. It should not break any
current code, but allows people to catch it if needed.

--mikko

On Mon, Jun 22, 2015 at 6:50 PM, rafzi [email protected] wrote:

I would offer to send a pull request for the core code, but it's not
really possible to fix the problem for users that are not notified about
this change, because they will need to check the return value of a function
that previously did not return a value.

Affected APIs would be:

rcAddSpan
rcAddSpans
rcRasterizeTriangle
rcRasterizeTriangles (3 overloads)

They all have a "ctx" parameter for error reporting though, so it would
only affect the return value change from void to bool.

—
Reply to this email directly or view it on GitHub
#100 (comment)
.

from recastnavigation.

@rafzi Did #102 complete everything you wanted to do with this? Are we ok to close this issue?

from recastnavigation.

Yes, this is done.

from recastnavigation.

Great - thanks!
On 31 Dec 2015 1:53 am, "rafzi" [email protected] wrote:

Yes, this is done.

—
Reply to this email directly or view it on GitHub
#100 (comment)
.

from recastnavigation.