Unable to make socket work about deployer HOT 7 CLOSED

OK I found the problem:

my instance of deployer runs in HTTPS with Let's Encrypt on top of Nginx. Because of this, my socket URL into the .env file is https:// too.
But in socket.js, I found these lines:

if (/^https/i.test(process.env.SOCKET_URL)) {
  const sslConfig = { ... }
}

So socket.io tries to create an SSL connection when Nginx is already handling this as a proxy.
The connection between Nginx and Socket.io is not supposed to use SSL, at least in my case because they use localhost, on the same server and because the 6001 port is closed in my firewall from the outside.

To fix it permanently, I guess there should be a new variable into the .env file:
SOCKET_SSL=true|false
and replace the previous source lines by:

if (process.env.SOCKET_SSL == true) {
  const sslConfig = { ... }
}

That would allow users to choose whether Nginx or Socket.io should handle the SSL connection or not.
That is what I did on my side and it works just fine.

Thanks

from deployer.

I think you need to change your nginx config to use the IP, just 127.0.0.1 for the node server, not the hostname

from deployer.

oops, sorry just realised server is just the server name, the upstream is the IP.

Hmm

from deployer.

Can you try starting the node server with DEBUG=* https://socket.io/docs/logging-and-debugging/ and see if there is any additional output in the supervisor log

from deployer.

Thanks, I did not know that DEBUG=* thing

root@dev:/tank/www/deployer# DEBUG=* node socket.js
  ioredis:redis status[127.0.0.1:6379]: [empty] -> connecting +0ms
  socket.io:server initializing namespace / +0ms
  socket.io-parser encoding packet {"type":0,"nsp":"/"} +0ms
  socket.io-parser encoded {"type":0,"nsp":"/"} as 0 +0ms
  socket.io:server creating engine.io instance with opts {"path":"/socket.io","initialPacket":["0"]} +1ms
  socket.io:server attaching client serving req handler +9ms
  socket.io:namespace removing initial packet +0ms
  ioredis:redis queue command[0] -> psubscribe(*) +32ms
  ioredis:redis status[127.0.0.1:6379]: connecting -> connect +4ms
  ioredis:redis write command[0] -> info() +1ms
  ioredis:redis status[127.0.0.1:6379]: connect -> ready +4ms
  ioredis:connection send 1 commands in offline queue +0ms
  ioredis:redis write command[0] -> psubscribe(*) +0ms

This line seems to be a problem:
ioredis:connection send 1 commands in offline queue +0ms (it's red in the output).
Redis is running
Thanks

from deployer.

I forgot to mention that deployments ARE working though. I just need to reload the page to check the status.

from deployer.

Hmm, this is really odd. Is there anything in the Redis log?

Yeah, deployments will continue to work, the websocket is only used for broadcasting updates to the client instead of doing AJAX polling.

from deployer.