Chart renders incorrectly when using StackedAreaChart with brush and zoom about reaviz HOT 6 OPEN

Thanks for the quick response!

I tried disabling the animation for the Series and Line, the drawing is faster but the bug still happens.
I will try to debug this method tomorrow.

from reaviz.

Oh - that is fun.

This is general area where this is happening: https://github.com/reaviz/reaviz/blob/master/src/AreaChart/AreaSeries/Line.tsx#L154

IF you turn off animations does it work?

from reaviz.

So I have found out that the issue starts here:
https://github.com/reaviz/reaviz/blob/master/src/AreaChart/AreaSeries/Line.tsx#L102

I tried different approaches that fix this issue:

1. Changing the condition in https://github.com/reaviz/reaviz/blob/master/src/AreaChart/AreaSeries/Line.tsx#L102:

   if (
     this.ghostPathRef.current &&
     (prevProps.data !== this.props.data ||
       prevProps.width !== this.props.width ||
       prevProps.xScale !== this.props.xScale ||
       prevProps.yScale !== this.props.yScale)
   ) {}

2. Spreading the data array in https://github.com/reaviz/reaviz/blob/master/src/AreaChart/AreaSeries/AreaSeries.tsx#L182 and https://github.com/reaviz/reaviz/blob/master/src/AreaChart/AreaSeries/AreaSeries.tsx#L197:

   -data={data}
   +data={[...data]}

3. Using the state in my component instead of the imported data and spreading the data array.

I'm no React expert but I think that if one of the solutions directly in the reaviz code is fine, it should be applied in a lot of places in the different charts, and I have no problem opening a PR.

from reaviz.

Ya - can you open up a PR - happy to accept that.

from reaviz.

I went with the first solution.
Let me know if you want me to create a story for this scenrio.

from reaviz.

Ya - add a story in the brush stories plz :D

from reaviz.