Here's three somewhat related tasks that make a nice unit of work. None of them are pa

I've got some questions: Should variants & extensible vari

Spacing cleanup: about reason HOT 7 CLOSED

reasonml commented on August 28, 2024

Spacing cleanup:

from reason.

Comments (7)

IwanKaramazow commented on August 28, 2024 1

I'm working on this.

from reason.

hcarty commented on August 28, 2024 1

A newline between type definitions and between modules helps a lot with readability. The one exception I can think of is recursively defined types (type a and type b).

from reason.

chenglou commented on August 28, 2024

Gonna bump this a bit. At least a space between different item types "e.g. types vs let" inside modules would be nice.

from reason.

jordwalke commented on August 28, 2024

Cool, I've wanted this for a long time!

from reason.

IwanKaramazow commented on August 28, 2024

I've got some questions:

Should variants & extensible variants be seen as the same group?

module NottyString = {
  type props = {
    attr,
    text: string,
    style: LayoutSupport.LayoutTypes.cssStyle,
    children: list element
  };

  type tag 'props +=
    | StringTag :tag props;

  let createElement ::attr=A.empty ::style=LayoutSupport.defaultStyle ::text children =>
    NativeElement StringTag {attr, text, style, children};
};

Should we group modules, module types and/or classes?
Example:

module NottyString = {
  type props = {
    attr,
    text: string,
    style: LayoutSupport.LayoutTypes.cssStyle,
    children: list element
  };

  type tag 'props +=
    | StringTag :tag props;

  let createElement ::attr=A.empty ::style=LayoutSupport.defaultStyle ::text children =>
    NativeElement StringTag {attr, text, style, children};
};
module Div = {
  type props = {style: LayoutSupport.LayoutTypes.cssStyle, children: list element};

  type tag 'props +=
    | VoidTag :tag props;

  let createElement ::style=LayoutSupport.defaultStyle children =>
    NativeElement VoidTag {style, children};
};

There's no spacing between module definition NottyString & module definition Div.

from reason.