Cannot find module 'number-is-nan' about reason HOT 8 CLOSED

Does this happen all the time? @cristianoc did not report this issue, so I'm assuming this was a one-off?

from reason.

It happens every time I open a reason file.

On Nov 27, 2015, at 12:12 PM, Jordan W [email protected] wrote:

Does this happen all the time? @cristianoc https://github.com/cristianoc did not report this issue, so I'm assuming this was a one-off?

—
Reply to this email directly or view it on GitHub #3 (comment).

from reason.

I'll look into this in about one hour.

from reason.

It looks like you're installing this from Homebrew, is that right? I have only been targeting the open source Atom. @cristianoc had problems on a non-standard version as well which went away when using the standard version. I'll continue to look into why there is a difference with your version (we should make it so that works too), but in the mean time could you try the version here? https://atom.io/

from reason.

In hopes of getting even this Homebrew setup working as well, I looked at what might be different in our installations.

The file node_modules/nuclide-client/node_modules/nuclide-service-parser/node_modules/babel-core/node_modules/repeating/node_modules/is-finite/index.js is trying to require number-is-nan. When doing so, it will look for it (relative to the location of index.js) in ./node_modules/number-is-nan/index.js. On my system, I have that file. The total path relative to the ide-reason plugin is:

node_modules/nuclide-client/node_modules/nuclide-service-parser/node_modules/babel-core/node_modules/repeating/node_modules/is-finite/node_modules/number-is-nan/index.js

Do you not have that file? If not, you could just wipe out the ide-reason/node_modules and rerun apm install. I'm eager to see if this fixes your problem.

from reason.

I had no node_modules directory in ~/.atom/packages/ide-reason/node_modules/nuclide-client/node_modules/nuclide-service-parser/node_modules/babel-core/node_modules/repeating/node_modules/is-finite.

But after removing ide-reason/node_modules and executing apm install, I do, so I don't know what happened before. I'm not getting errors from atom anymore, and the reformatter, etc. are working, so score!

On Nov 27, 2015, at 9:52 PM, Jordan W [email protected] wrote:

In hopes of getting even this Homebrew setup working as well, I looked at what might be different in our installations.

The file node_modules/nuclide-client/node_modules/nuclide-service-parser/node_modules/babel-core/node_modules/repeating/node_modules/is-finite/index.js is trying to require number-is-nan. When doing so, it will look for it (relative to the location of index.js) in ./node_modules/number-is-nan/index.js. On my system, I have that file. The total path relative to the ide-reason plugin is:

node_modules/nuclide-client/node_modules/nuclide-service-parser/node_modules/babel-core/node_modules/repeating/node_modules/is-finite/node_modules/number-is-nan/index.js
Do you not have that file? If not, you could just wipe out the ide-reason/node_modules and rerun apm install. I'm eager to see if this fixes your problem.

—
Reply to this email directly or view it on GitHub #3 (comment).

from reason.

Yes, homebrew, but for the record, it just downloads the archive from https://github.com/atom/atom/releases/download/v#{version}/atom-mac.zip, the same place that atom.io points to.

On Nov 27, 2015, at 9:42 PM, Jordan W [email protected] wrote:

It looks like you're installing this from Homebrew, is that right? I have only been targeting the open source Atom. @cristianoc https://github.com/cristianoc had problems on a non-standard version as well which went away when using the standard version. I'll continue to look into why there is a difference with your version (we should make it so that works too), but in the mean time could you try the version here? https://atom.io/ https://atom.io/
—
Reply to this email directly or view it on GitHub #3 (comment).

from reason.

Closing since reinstalling seems to have fixed it. We'll chalk it up to solar flares.

from reason.